Skip to content

TextBox: Removed not needed VerticalAlignment and it now respects VerticalContentAlignment #3162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Keboo merged 4 commits into from
Apr 16, 2023
Merged

TextBox: Removed not needed VerticalAlignment and it now respects VerticalContentAlignment #3162

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
20f51a7
Removed not needed VerticalAlignment
nicolaihenriksen Apr 8, 2023
0945e64
Add support for TextBox.VerticalContentAlignment
nicolaihenriksen Apr 8, 2023
a629421
Added UI test for all VerticalAlignment scenarios
nicolaihenriksen Apr 8, 2023
e5a3c7f
Fixed broken test
nicolaihenriksen Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Removed not needed VerticalAlignment
  • Loading branch information
@nicolaihenriksen
nicolaihenriksen committed Apr 8, 2023
commit 20f51a7b981b16d90e9324f4f37655c6bf4bd815
2 changes: 0 additions & 2 deletions MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.PasswordBox.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,6 @@
</Grid.ColumnDefinitions>
<Grid x:Name="grid"
MinWidth="1"
VerticalAlignment="Center"
HorizontalAlignment="Stretch">
<Grid.ColumnDefinitions>
<ColumnDefinition Width="Auto" />
Expand Down Expand Up @@ -604,7 +603,6 @@
</Grid.ColumnDefinitions>
<Grid x:Name="grid"
MinWidth="1"
VerticalAlignment="Center"
HorizontalAlignment="Stretch">
<Grid.ColumnDefinitions>
<ColumnDefinition Width="Auto" />
Expand Down
1 change: 0 additions & 1 deletion MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.TextBox.xaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@
<Grid x:Name="grid"
Grid.Column="1"
MinWidth="1"
VerticalAlignment="Center"
HorizontalAlignment="Stretch">
<Grid Grid.Column="0">
<Grid.ColumnDefinitions>
Expand Down