Skip to content

Fix issue that IME gets misplaced when text input control is on a Popup #3292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Keboo merged 2 commits into from
Aug 13, 2023
Merged

Fix issue that IME gets misplaced when text input control is on a Popup #3292

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a0b311f
Fix issue that IME gets misplaced when text input control is on a Popup
AndrewKeepCoding Aug 11, 2023
ec1c2e3
Fixing UI tests with new XAMLTest version
Keboo Aug 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fixing UI tests with new XAMLTest version
  • Loading branch information
@Keboo
Keboo committed Aug 13, 2023
commit ec1c2e36fba132786c1fdacab1d04d2880807f44
2 changes: 1 addition & 1 deletion Directory.packages.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<PackageVersion Include="ShowMeTheXAML.AvalonEdit" Version="2.0.0" />
<PackageVersion Include="ShowMeTheXAML.MSBuild" Version="2.0.0" />
<PackageVersion Include="VirtualizingWrapPanel" Version="1.5.7" />
<PackageVersion Include="XAMLTest" Version="1.0.0-ci417" />
<PackageVersion Include="XAMLTest" Version="1.0.0-ci451" />
<PackageVersion Include="xunit" Version="2.5.0" />
<PackageVersion Include="xunit.runner.visualstudio" Version="2.5.0" />
<PackageVersion Include="Xunit.StaFact" Version="1.1.11" />
Expand Down
8 changes: 4 additions & 4 deletions MaterialDesignThemes.UITests/WPF/ListBoxes/ListBoxTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,17 +105,17 @@ public async Task ScrollBarAssist_ButtonsVisibility_HidesButtonsOnMinimalistStyl
var verticalScrollBar = await listBox.GetElement<ScrollBar>("PART_VerticalScrollBar");
var horizontalScrollBar = await listBox.GetElement<ScrollBar>("PART_HorizontalScrollBar");

Assert.Equal(17, await verticalScrollBar.GetActualWidth());
Assert.Equal(17.0, await verticalScrollBar.GetActualWidth(), 1.0);
var verticalThumb = await verticalScrollBar.GetElement<Border>("/Thumb~border");
Assert.Equal(10, await verticalThumb.GetActualWidth());
Assert.Equal(10.0, await verticalThumb.GetActualWidth(), 1.0);
var upButton = await verticalScrollBar.GetElement<RepeatButton>("PART_LineUpButton");
Assert.False(await upButton.GetIsVisible());
var downButton = await verticalScrollBar.GetElement<RepeatButton>("PART_LineDownButton");
Assert.False(await downButton.GetIsVisible());

Assert.Equal(17, await horizontalScrollBar.GetActualHeight());
Assert.Equal(17.0, await horizontalScrollBar.GetActualHeight(), 1.0);
var horizontalThumb = await horizontalScrollBar.GetElement<Border>("/Thumb~border");
Assert.Equal(10, await horizontalThumb.GetActualHeight());
Assert.Equal(10.0, await horizontalThumb.GetActualHeight(), 1.0);
var leftButton = await horizontalScrollBar.GetElement<RepeatButton>("PART_LineLeftButton");
Assert.False(await leftButton.GetIsVisible());
var rightButton = await horizontalScrollBar.GetElement<RepeatButton>("PART_LineRightButton");
Expand Down