-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Smart hint and text box style refactor #3486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
65 commits
Select commit
Hold shift + click to select a range
3af9076
Initial TextBox style changes added
nicolaihenriksen 5583933
Temporarily fix AutoSuggestBox by bringing in old converters directly…
nicolaihenriksen 23a613b
Add character counter toggle to demo app
nicolaihenriksen b7bb541
Basics of SmartHint refactor in place - edge cases need attention
nicolaihenriksen e1c40fa
Fix "padding" issues for outlined style by letting the padding animat…
nicolaihenriksen 56d82b1
Fix AcceptsReturn=True scenario for TextBox use of SmartHint
nicolaihenriksen 2e7be56
Smart hint page in demo app handles its own scrolling
nicolaihenriksen f5cd136
Improve handling of dynamic FontSize changes
nicolaihenriksen a4cb453
Add TextFieldAssist.IconVerticalAlignment AP to control icon placemen…
nicolaihenriksen 8b76a7e
Add APs for controlling prefix/suffix visibility and floating hint al…
nicolaihenriksen c2cf3ca
DP cleanup
nicolaihenriksen 8c2d0e3
Smart Hint demo app page cleanup
nicolaihenriksen bd4462b
Let hint span accross prefix/suffix texts
nicolaihenriksen c1c9ca9
Update demo app Smart Hint page with selectors for new APs
nicolaihenriksen 2da8e16
Make prefix/suffix visibility converter respect new AP
nicolaihenriksen 854f8dc
Decent working state; special cases where hint should also animate ho…
nicolaihenriksen 62bbf85
Fix horizontal animation of hint cases
nicolaihenriksen 4f1ce92
Mark converters for obsoletion/deletion
nicolaihenriksen aa01197
Remove no longer used converter
nicolaihenriksen 80c748d
Move SmartHint converters into their own files
nicolaihenriksen 9a57421
Temporarily change startup page to SmartHint
nicolaihenriksen 2f94000
Fix FloatingHintInitialHorizontalOffsetConverter logic
nicolaihenriksen 1c75566
Update MainDemo.Wpf/SmartHint.xaml
nicolaihenriksen 6150e10
Update MainDemo.Wpf/SmartHint.xaml
nicolaihenriksen ed81317
Update MainDemo.Wpf/SmartHint.xaml
nicolaihenriksen 9b8b71e
Update MainDemo.Wpf/SmartHint.xaml
nicolaihenriksen 23e304f
Update MainDemo.Wpf/SmartHint.xaml
nicolaihenriksen 2c3e6e5
Update MaterialDesignThemes.Wpf/Converters/FloatingHintMarginConverte…
nicolaihenriksen 7af4211
Renamed converter values
nicolaihenriksen d93e345
Update MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.SmartHint.…
nicolaihenriksen 1bca5eb
Implement BooleanToDashStyleConverter.ConvertBack()
nicolaihenriksen d522441
Remove dead code
nicolaihenriksen 7607392
Handle HasErrors=True margin correction
nicolaihenriksen 2f17f44
Fix support for TextFieldAssist.NewSpecHighlightingEnabled=True
nicolaihenriksen 98b16f2
Add TextFieldAssist.NewSpecHighlightingEnabled support on demo app Sm…
nicolaihenriksen 4c79c00
Add options to control scroll bar visibility on SmartHint demo page (…
nicolaihenriksen 5833970
Slightly nicer layout for scroll bar options on SmartHint demo page
nicolaihenriksen cf2cd7a
Fix "accepts return" check box to use VM binding
nicolaihenriksen 96ef473
Temporarily add defaults to showcase the horizontal scrollbar issue
nicolaihenriksen 8f4fc67
Include RD for missing static resource
nicolaihenriksen d317d22
PoC fix for the VerticalContentAlignment=Stretch issue
nicolaihenriksen 6b1ce17
Fix demo app layout and defaults after rebase
nicolaihenriksen c5f6e5b
Leverage list pattern matching in relevant converters
nicolaihenriksen 344dc1a
Cleanup constants and "hide" temporary constants in an internal class.
nicolaihenriksen e11a573
Fix for TextBoxTests.FilledTextBox_ValidationErrorMargin_MatchesHelpe…
nicolaihenriksen 785f69c
Fix for TextBoxTests.HelperText_CanSetFontColorWithAttachedStyle()
nicolaihenriksen cfc8b76
Fix for TextBoxTests.OnClearButtonShown_ControlHeightDoesNotChange()
nicolaihenriksen 0c722f2
Deleted TextBoxTests.OnOutlinedTextBox_FloatingHintOffsetWithinRange(…
nicolaihenriksen 2795619
Fix for TextBoxTests.OnTextBoxDisabled_FloatingHintBackgroundIsOpaque()
nicolaihenriksen 63de7b4
Fix for TextBoxTests.OutlinedTextBox_ValidationErrorMargin_MatchesHel…
nicolaihenriksen 9f9c924
Fix for TextBoxTests.TextBox_MultiLineAndFixedHeight_RespectsVertical…
nicolaihenriksen 5de85bd
Adjust default paddings to for better looks, and temporary make the U…
nicolaihenriksen 0180b65
Merge duplicate triggers
nicolaihenriksen 800f3bc
Add dedicated "MaterialDesign.Brush.TextBox.HoverBorder" brush
nicolaihenriksen d6462d8
Use new hover brush for the filled TextBox style
nicolaihenriksen f289bf7
Minor code cleanup
Keboo 932656a
New brush is now an alternate rather than an obsolete brush
nicolaihenriksen db948d1
Fix issue with HintAssist.IsFloating wrongfully affecting the hint te…
nicolaihenriksen 94e5677
Cherry-pick FloatingHintMarginConverter from ComboBox branch
nicolaihenriksen 1485de4
Add additional binding to use of FloatingHintMarginConverter
nicolaihenriksen 691074d
Add IsEditable parameter to prefix/suffix converter (taken from Combo…
nicolaihenriksen f5f4fe8
Split failing default height tests into pre- and post-smarthint-refactor
nicolaihenriksen 1d758ce
Fix jumpy UI when validation errors and color hint text red
nicolaihenriksen 9d21ca1
Set MinHeight=16 and separate all tests into pre-/post-refactor
nicolaihenriksen 9a7db19
Remove MaxWidth from demo app page
nicolaihenriksen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix "padding" issues for outlined style by letting the padding animat…
…e from 0 to desired size
- Loading branch information
commit e1c40faeceae59b8b1214c5fbf8bb7ce51ba1690
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.