Updated script to include file links (Issue#1380) #3750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keboo
reviewed
Dec 27, 2024
Member
Keboo
left a comment
Keboo
left a comment
There was a problem hiding this comment.
This is really great work. One small comment then we can merge it.
build/GenerateThemesWikiMarkdown.ps1
Outdated
Comment on lines
78
to
90
| Param ($xamlString, $file, $xamlPath) | ||
| [xml]$xaml = $xamlString | ||
| $xaml.ResourceDictionary.Style | | ||
| Foreach-Object { | ||
| $xamlLines = Get-Content $xamlPath | ||
| $lineNum = 1 | ||
| $xaml.ResourceDictionary.Style | | ||
| Foreach-Object { | ||
| Write-Output $_ | ||
| # Get line number by Key or TargetType | ||
| $styleLineNumber = $null | ||
| $searchKey = if ($_.Key) { $_.Key } else { $_.TargetType } | ||
|
|
||
| for ($i = 0; $i -lt $xamlLines.Length; $i++) { | ||
| if ($xamlLines[$i] -match [regex]::Escape($searchKey)) { |
Member
There was a problem hiding this comment.
I think $xamlPath is not needed as I believe you already have the content in $xamlString though this variable could probably be renamed to be $xamlLines.
Contributor
Author
There was a problem hiding this comment.
Alright, I've made the changes.
refactored xamlString to xamlLines and removed xamlPath var
Keboo
approved these changes
Dec 27, 2024
This was referenced Sep 26, 2025
This was referenced Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1380
Let me know if anything is breaking :)