Modify DecimalUpDown basic test to ensure culture is respected in string-value conversions #3865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keboo
approved these changes
Jun 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous PR (#3860 ) fixed the culture issue, but I was unable to write a UI test for it. This PR leverages the new XAMLTest API for
App.RemoteExecute(...)to get some testing in place.Changes included:
net9.0-windows9.0.300net9.0as wellDecimalUpDowntest to make it actually use a decimal incrementDecimalUpDowntest to be data-driven for a given set of culturesen-US,da-DK(my own), and a couple of others I suspect could be problematic.Update
Reverting #3860 temporarily, yields these test results, so perhaps my choice of cultures was not that great 😛