Used x:Reference in Button and ProgressBar ControlTemplates #3868
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
This indeed fixes the binding failures. |
JorisCleVR
added a commit
to CleVR-bv/MaterialDesignInXamlToolkit
that referenced
this pull request
Jul 18, 2025
JorisCleVR
added a commit
to CleVR-bv/MaterialDesignInXamlToolkit
that referenced
this pull request
Aug 22, 2025
Keboo
pushed a commit
that referenced
this pull request
Aug 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3814
Used x:Reference in Button and ProgressBar ControlTemplates to fix some binding errors.
The issue is that ElementName does a Runtime lookup of the element. At some moments in time or on freezable objects this does not work, because they are not available in the visual tree. Therefore within a ControlTemplate x:Reference can be used to do a compile time / load time lookup.
Note that because the lookup is compile time / load time this also has a small performance gain during load of the element.