Skip to content

Fix some nits #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
HyukjinKwon merged 1 commit into from
Oct 16, 2018
Merged

Fix some nits #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/csvExpressions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,7 @@ case class CsvToStructs(
@transient
lazy val converter = (rows: Iterator[InternalRow]) => {
if (rows.hasNext) {
rows.next()
val result = rows.next
val result = rows.next()
// CSV's parser produces one record only.
assert(!rows.hasNext)
result
Expand Down
2 changes: 1 addition & 1 deletion ...park/sql/catalyst/csv/CSVUtilsSuite.scala → .../sql/catalyst/csv/CSVExprUtilsSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ package org.apache.spark.sql.catalyst.csv

import org.apache.spark.SparkFunSuite

class CSVExpressionUtilsSuite extends SparkFunSuite {
class CSVExprUtilsSuite extends SparkFunSuite {
test("Can parse escaped characters") {
assert(CSVExprUtils.toChar("""\t""") === '\t')
assert(CSVExprUtils.toChar("""\r""") === '\r')
Expand Down