Skip to content

Revise and optimise PMSL calculation #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iboutle wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Revise and optimise PMSL calculation #348

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
df48745
copy changes to vn3 branch
james-bruten-mo Feb 6, 2026
8c65135
remove makefile additions
james-bruten-mo Feb 6, 2026
e73ff69
first attempt at pmsl speed up
iboutle Feb 12, 2026
81310af
bugfix
iboutle Feb 13, 2026
c196859
updates to generic halo depth
iboutle Mar 6, 2026
6d40cc6
reduce number of iterations in global model
iboutle Mar 6, 2026
0e1e209
Merge branch 'vn3.0_pmsl' into vn3.1_pmsl
iboutle Mar 6, 2026
2d20463
fix licence
iboutle Mar 6, 2026
3f55c0a
core branch for geometric constants
iboutle Mar 9, 2026
4650c99
tidy up
iboutle Mar 9, 2026
e58f275
utility routine added
iboutle Mar 9, 2026
7521c5e
add upgrade macro
iboutle Mar 9, 2026
4e651ab
metadata fix
iboutle Mar 9, 2026
b704a4d
fix for upgrade macro
iboutle Mar 12, 2026
f9e6236
Update interfaces/physics_schemes_interface/source/algorithm/pmsl_alg…
iboutle Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update interfaces/physics_schemes_interface/source/algorithm/pmsl_alg… 
…_mod.x90

Co-authored-by: Thomas Bendall <14180399+tommbendall@users.noreply.github.com>
  • Loading branch information
@iboutle @tommbendall
iboutle and tommbendall authored Mar 13, 2026
commit f9e62364c96d262677e65ad69fb0bfa3f039e9ad
2 changes: 1 addition & 1 deletion interfaces/physics_schemes_interface/source/algorithm/pmsl_alg_mod.x90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ contains

! Iterative solver for exner - this loops to depth 'm' in the halo
! thus only requiring a halo exchange once every m iterations
! Larger m values will thus to more computation but fewer halo exchanges
! Larger m values will thus do more computation but fewer halo exchanges
counter = 0
outer: do n = 1, n_iter_pmsl/max_halo_depth+1
do m = max_halo_depth-1,0,-1
Expand Down