This repository was archived by the owner on Oct 7, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 126
Update module configuration #230
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
663db30
Update project configuration
gantunesr dfe207a
Update project configuration
gantunesr 264f75d
Update PR template
gantunesr 8312377
Update configuration
gantunesr a38872a
Update node version to 14
gantunesr ab62050
Solve lint issue
gantunesr 55e761e
Update coverageThreshold
gantunesr 0c9629e
Update node version in build-lint-test workflow
gantunesr 0da6e06
Add step to clear cache
gantunesr 4f6737a
Revert "Add step to clear cache"
gantunesr 869b481
Add step to clear cache
gantunesr 3a20107
Revert "Add step to clear cache"
gantunesr 9120050
Solve typo
gantunesr b634fe2
Update .github/pull_request_template.md
gantunesr d7f8b4d
Update .github/pull_request_template.md
gantunesr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update PR template
- Loading branch information
commit 264f75d0501b755cd443b8a32f299bfeeaafce6e
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,46 @@ | ||
| ## Description | ||
|
|
||
| <!-- | ||
| Thanks for your contribution! Take a moment to answer these questions so that reviewers have the information they need to properly understand your changes: | ||
|
|
||
| * What is the current state of things and why does it need to change? | ||
| * What is the solution your changes offer and how does it work? | ||
| * What packages are you updating? | ||
| * Are you introducing a breaking change to a package (renaming or removing a part of a public interface)? | ||
gantunesr marked this conversation as resolved.
Outdated
Show resolved
Hide resolved
|
||
| --> | ||
|
|
||
| Are there any issues or other links reviewers should consult to understand this pull request better? For instance: | ||
| ## Changes | ||
|
|
||
| * Fixes #12345 | ||
| * See: #67890 | ||
| <!-- | ||
| Pretend that you're updating a changelog. How would you categorize your changes? | ||
|
|
||
| CATEGORY is one of: | ||
|
|
||
| - BREAKING | ||
| - ADDED | ||
| - CHANGED | ||
| - DEPRECATED | ||
| - REMOVED | ||
| - FIXED | ||
|
|
||
| (Security-related changes should go through the Security Advisory process.) | ||
| --> | ||
|
|
||
| ## Examples | ||
| - **<CATEGORY>**: Your change here | ||
| - **<CATEGORY>**: Your change here | ||
| - **<CATEGORY>**: Your change here | ||
|
|
||
| ## References | ||
|
|
||
| <!-- | ||
| Are there any examples of this change being used in another repository? | ||
| Are there any issues or other links that reviewers should consult to understand this pull request better? For instance: | ||
|
|
||
| When considering changes to the MetaMask module template, it's strongly preferred that the change be experimented with in another repository first. This gives reviewers a better sense of how the change works, making it less likely the change will need to be reverted or adjusted later. | ||
| * Fixes #12345 | ||
| * See: #67890 | ||
| --> | ||
|
|
||
| ## Checklist | ||
|
|
||
| - [ ] I've updated the test suite for new or updated code as appropriate | ||
| - [ ] I've updated documentation for new or updated code as appropriate (note: this will usually be JSDoc) | ||
| - [ ] I've highlighted breaking changes using the "BREAKING" category above as appropriate | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.