feat: support OneKey #335
feat: support OneKey #335
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
All alerts resolved. Learn more about Socket for GitHub. This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
ByteZhang1024
force-pushed
the
feat/onekey
branch
from
490ac87 to
04710f6
Compare
|
@metamaskbot publish-preview |
ByteZhang1024
force-pushed
the
feat/onekey
branch
from
e965ecf to
a18c779
Compare
|
@metamaskbot publish-preview |
ByteZhang1024
force-pushed
the
feat/onekey
branch
from
7f71d7a to
a621908
Compare
| chainId: 1, | ||
| path: this.#getBasePath(), | ||
| passphraseState: this.passphraseState ?? '', | ||
| }) |
There was a problem hiding this comment.
Bug: Unlock Method Missing Coin Parameter
The unlock method calls bridge.getPublicKey with an incorrect parameter set. It includes chainId and showOnOneKey but misses the required coin parameter for the bridge. Also, this.passphraseState is assigned redundantly in this method.
|
@ByteZhang1024 closed in favor of #353 Please dm me whenever I need to update the new PR with your changes. |
2 participants
Examples
See: #32739