Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
feat: fix createAccounts for client v2
  • Loading branch information
ccharly committed Dec 5, 2025
commit 6b260f0640c5a54a88a2d16ca6f51399a15029e9
10 changes: 8 additions & 2 deletions packages/keyring-snap-client/src/v2/KeyringClientV2.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -81,13 +81,19 @@ describe('KeyringClient', () => {
},
];

const createAccountOptions = {
type: 'bip44:derive-index',
entropySource: 'mock-entropy-source',
groupIndex: 0,
} as const;

mockSender.send.mockResolvedValue(expectedResponse);
const account = await client.createAccounts();
const account = await client.createAccounts(createAccountOptions);
expect(mockSender.send).toHaveBeenCalledWith({
jsonrpc: '2.0',
id: expect.any(String),
method: `${KeyringRpcV2Method.CreateAccounts}`,
params: { options: {} },
params: createAccountOptions,
});
expect(account).toStrictEqual(expectedResponse);
});
Expand Down
5 changes: 3 additions & 2 deletions packages/keyring-snap-client/src/v2/KeyringClientV2.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ import {
ExportAccountV2ResponseStruct,
} from '@metamask/keyring-api';
import type {
CreateAccountOptions,
ExportAccountOptions,
ExportedAccount,
KeyringAccount,
Expand Down Expand Up @@ -73,14 +74,14 @@ export class KeyringClientV2 implements KeyringRpcV2 {
}

async createAccounts(
options: Record<string, Json> = {},
params: CreateAccountOptions,
): Promise<KeyringAccount[]> {
return strictMask(
await this.send({
jsonrpc: '2.0',
id: uuid(),
method: KeyringRpcV2Method.CreateAccounts,
params: { options },
params,
}),
CreateAccountsV2ResponseStruct,
);
Expand Down
Loading