Skip to content

feat: add QrKeyringV2 wrapper #411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mathieuartu wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: add QrKeyringV2 wrapper #411

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e42077c
feat: wip
mathieuartu Dec 8, 2025
c14f22b
feat: default to bip44 accounts and simplify flows
mathieuartu Dec 10, 2025
b910609
fix: refine UTs + fix eslint errors
mathieuartu Dec 10, 2025
7aa6062
fix: update tsconfig.build.json
mathieuartu Dec 10, 2025
0e59299
fix: update README
mathieuartu Dec 10, 2025
a0b7e05
fix: better UT structure
mathieuartu Dec 10, 2025
6796f3b
fix: update CHANGELOG
mathieuartu Dec 10, 2025
aa6f016
fix: address some PR feedbacks
mathieuartu Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,9 @@ linkStyle default opacity:0.5
eth_hd_keyring --> keyring_utils;
eth_hd_keyring --> account_api;
eth_ledger_bridge_keyring --> keyring_utils;
eth_qr_keyring --> keyring_api;
eth_qr_keyring --> keyring_utils;
eth_qr_keyring --> account_api;
eth_simple_keyring --> keyring_api;
eth_simple_keyring --> keyring_utils;
eth_trezor_keyring --> keyring_utils;
Expand Down
1 change: 1 addition & 0 deletions packages/keyring-eth-hd/src/hd-keyring-v2.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,6 +116,7 @@ export class HdKeyringV2
groupIndex: addressIndex,
derivationPath: `${this.inner.hdPath}/${addressIndex}`,
},
exportable: true,
},
};

Expand Down
6 changes: 6 additions & 0 deletions packages/keyring-eth-qr/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

## [Unreleased]

### Added

- Add `QrKeyringV2` class implementing `KeyringV2` interface ([#411](https://github.com/MetaMask/accounts/pull/411))
- Wraps legacy `QrKeyring` to expose accounts via the unified `KeyringV2` API and the `KeyringAccount` type.
- Extends `EthKeyringWrapper` for common Ethereum logic.

## [1.1.0]

### Added
Expand Down
2 changes: 2 additions & 0 deletions packages/keyring-eth-qr/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@
"@ethereumjs/util": "^9.1.0",
"@keystonehq/bc-ur-registry-eth": "^0.19.1",
"@metamask/eth-sig-util": "^8.2.0",
"@metamask/keyring-api": "workspace:^",
"@metamask/keyring-utils": "workspace:^",
"@metamask/utils": "^11.1.0",
"async-mutex": "^0.5.0",
Expand All @@ -63,6 +64,7 @@
"@ethereumjs/common": "^4.4.0",
"@keystonehq/metamask-airgapped-keyring": "^0.15.2",
"@lavamoat/allow-scripts": "^3.2.1",
"@metamask/account-api": "workspace:^",
"@metamask/auto-changelog": "^3.4.4",
"@types/hdkey": "^2.0.1",
"@types/jest": "^29.5.12",
Expand Down
1 change: 1 addition & 0 deletions packages/keyring-eth-qr/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,3 +17,4 @@ export {
type SerializedQrKeyringState,
type SerializedUR,
} from './qr-keyring';
export { QrKeyringV2, type QrKeyringV2Options } from './qr-keyring-v2';
Loading
Loading