-
-
Notifications
You must be signed in to change notification settings - Fork 5
feat: add SAST onboarding automation #72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 1 commit
ec21c3e
89f2c4e
ad24efa
e283983
acbbe22
10735dd
8f971de
27e6a83
ecc9d0a
ae1d8e4
da090b6
6d3ad6b
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -49,13 +49,13 @@ jobs: | |
| echo "base_branch=$BASE_BRANCH" >> $GITHUB_OUTPUT | ||
| shell: bash | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GH_TOKEN: ${{ secrets.ONBOARDING_TOKEN }} | ||
|
|
||
| - name: Checkout target repository | ||
| uses: actions/checkout@v4 | ||
| with: | ||
| repository: ${{ steps.target.outputs.repository }} | ||
| token: ${{ secrets.GITHUB_TOKEN }} | ||
| token: ${{ secrets.ONBOARDING_TOKEN }} | ||
| path: target-repo | ||
| ref: ${{ steps.target.outputs.base_branch }} | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: Opt-out file check documented but never implementedThe PR body template tells users to add a Additional Locations (1) |
||
|
|
||
|
|
@@ -94,7 +94,7 @@ jobs: | |
| - name: Create Pull Request | ||
| working-directory: target-repo | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GH_TOKEN: ${{ secrets.ONBOARDING_TOKEN }} | ||
| REPO_NAME: ${{ steps.target.outputs.repository }} | ||
| run: | | ||
| # Extract owner and repo name for URL construction | ||
|
|
@@ -117,7 +117,7 @@ jobs: | |
| - name: Output PR URL | ||
| working-directory: target-repo | ||
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| GH_TOKEN: ${{ secrets.ONBOARDING_TOKEN }} | ||
| run: | | ||
| PR_URL=$(gh pr view security/add-sast-scanner --json url -q .url) | ||
| echo "✅ Pull Request created: $PR_URL" | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Opt-out file check documented but never implemented
The PR body template instructs users to add a
.github/no-security-scannerfile to prevent future onboarding attempts, but the workflow never checks for this file's existence. The onboarding will proceed regardless of whether a team has opted out, making the documented opt-out mechanism non-functional.Additional Locations (1)
.github/templates/onboarding-pr-body-automated.md#L8-L9