generated from MetaMask/metamask-module-template
-
-
Notifications
You must be signed in to change notification settings - Fork 4
Parse changelog entry adjustments #248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
gauthierpetetin
merged 15 commits into
parse-changelog-entry
from
parse-changelog-entry-adjustments
Sep 17, 2025
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ab9cb79
set keywordsToIndicateExcluded to lowercase
gauthierpetetin 59fbc92
make changelog generation idempotent
gauthierpetetin 168ff78
remove console.log
gauthierpetetin 93a67af
Add a default value for useShortPrLink
gauthierpetetin 688c73a
fix extractPrLinks function to pass unit tests
gauthierpetetin 3298e52
add unit tests
gauthierpetetin 3a32aab
Fix for 1: Syntax error: '(' unexpected' error
XxdpavelxX 0b8e0cb
Auto-changelog cleanup
XxdpavelxX 811057d
Set keywordsToIndicateExcluded to lowercase only once
gauthierpetetin 53d0041
Revert "Auto-changelog cleanup"
XxdpavelxX 9b8bc4a
Revert "Fix for 1: Syntax error: '(' unexpected' error"
XxdpavelxX 890f2ab
Deduplicate unit tests
gauthierpetetin 840d6e9
fix lint
HowardBraham 077c44a
store repoUrl in a const
HowardBraham 017c370
Remove outer backticks and conventional commit prefix if present
gauthierpetetin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix for 1: Syntax error: '(' unexpected' error
Signed-off-by: Pavel Dvorkin <[email protected]>
- Loading branch information
commit 3a32aab8c64d530b68194f9d6a7c39ee0922c0f7
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| #!/usr/bin/env node | ||
| (async () => { | ||
| try { | ||
| await import('../dist/cli.mjs'); | ||
| } catch (error) { | ||
| try { | ||
| // Fallback to CommonJS build if ESM import fails | ||
| // eslint-disable-next-line @typescript-eslint/no-var-requires, import/no-commonjs, @typescript-eslint/no-require-imports | ||
| require('../dist/cli.cjs'); | ||
| } catch (fallbackError) { | ||
| // Prefer showing the original error if present | ||
| // eslint-disable-next-line no-console | ||
| console.error(error || fallbackError); | ||
| process.exit(1); | ||
| } | ||
| } | ||
| })(); | ||
|
|
||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: CLI Entry Point Mismatch Causes Runtime Failures
The
package.jsonbinfield points todist/cli.js, while thechangelogscript usesdist/cli.mjs. This creates an inconsistency in the CLI entry points. Additionally, the intended binary isbin/auto-changelog.js, which isn't referenced by thebinfield. This mismatch may cause the globally installed CLI or npm script to use incorrect files, leading to runtime failures.