Skip to content

WIP: Expose MultichainApiClient provider with a transport adapter without needing to connect first #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jiexi wants to merge 8 commits into
base: main
Choose a base branch
from
Open

WIP: Expose MultichainApiClient provider with a transport adapter without needing to connect first #45

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
9b39202
add provider proxy
jiexi Nov 21, 2025
80c7884
fix provider getter
jiexi Nov 21, 2025
6cb57fb
update provider proxy
jiexi Nov 21, 2025
3db0e50
use providerProxy instead of actual provider
jiexi Nov 21, 2025
1ebcfeb
add session properties
jiexi Nov 21, 2025
32aca34
add rpc-errors
jiexi Nov 21, 2025
cf8c4d8
replace provider proxy with MultichainApiClientWrapperTransport
jiexi Nov 21, 2025
b55e937
Fix transport check
jiexi Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
use providerProxy instead of actual provider
  • Loading branch information
@jiexi
jiexi committed Nov 21, 2025
commit 3db0e50c7e7e83d0923848bbaa1926d812c4d8cd
12 changes: 0 additions & 12 deletions packages/connect-multichain/src/multichain/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,6 @@ export { getInfuraRpcUrls } from '../domain/multichain/api/infura';
const logger = createLogger('metamask-sdk:core');

export class MultichainSDK extends MultichainCore {
private __provider: MultichainApiClient<RPCAPI> | undefined = undefined;
private __providerProxy = createProviderProxy(this);

private __transport: ExtendedTransport | undefined = undefined;
Expand All @@ -103,15 +102,6 @@ export class MultichainSDK extends MultichainCore {
}

get provider(): MultichainApiClient<RPCAPI> {
if (this.__provider) {
return this.__provider;
}

if (this.__transport) {
this.__provider = getMultichainClient({ transport: this.__transport });
return this.__provider;
}

return this.__providerProxy;
}

Expand Down Expand Up @@ -595,14 +585,12 @@ export class MultichainSDK extends MultichainCore {
this.listener = undefined;
this.__beforeUnloadListener = undefined;
this.__transport = undefined;
this.__provider = undefined;
this.__dappClient = undefined;
}

async invokeMethod(request: InvokeMethodOptions): Promise<Json> {
const { sdkInfo, transport, options } = this;

this.__provider ??= getMultichainClient({ transport });

const rpcClient = new RpcClient(options, sdkInfo);
const requestRouter = new RequestRouter(transport, rpcClient, options);
Expand Down