improve mwp connection management #84
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix stuck CONNECTING state in MWPTransport
Problem
The
MWPTransport.connect()method could leave the underlyingDappClientstuck in aCONNECTINGstate, causing subsequent connection attempts to fail with"Cannot connect when state is CONNECTING".Root Causes
connect()would attempt to calldappClient.connect()simultaneously'message'handler registered during connection was never removed, causing memory leaks and duplicate handlers on reconnectiondappClient.resume()threw, the'connected'event listener would hang indefinitelyonResumeSuccess– Errors from this async function were not properly caughtChanges
connectionPromiseto track in-progress connections and return the existing promise on concurrent callsconnectionMessageHandler) on success, failure, timeout, and disconnectresume()errors by removing the'connected'listener and rejecting the promiseonResumeSuccess()with.catch()to surface errors