Skip to content

Bump Yarn to v4 #3612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mcmire merged 11 commits into from
Jun 27, 2024
Merged

Bump Yarn to v4 #3612

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4b4cbe7
Bump Yarn to 4.2.2
mcmire Dec 1, 2023
54f60dc
Bump to action-npm-publish v5
mcmire Jun 7, 2024
c26ba43
Merge branch 'main' into bump-to-yarn-v4
mcmire Jun 7, 2024
db29601
Merge branch 'main' into bump-to-yarn-v4
mcmire Jun 10, 2024
61b57b3
Merge branch 'main' into bump-to-yarn-v4
mcmire Jun 11, 2024
ff9e020
Merge branch 'main' into bump-to-yarn-v4
mcmire Jun 13, 2024
7f59063
Merge branch 'main' into bump-to-yarn-v4
mcmire Jun 18, 2024
2cceb92
Merge branch 'main' into bump-to-yarn-v4
mcmire Jun 26, 2024
aa08a3c
Merge branch 'main' into bump-to-yarn-v4
mcmire Jun 26, 2024
5cb41fb
Merge branch 'main' into bump-to-yarn-v4
mcmire Jun 27, 2024
62bf5e6
Don't install dependencies for publish-npm-dry-run and publish-npm jobs
mcmire Jun 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Bump to action-npm-publish v5
  • Loading branch information
@mcmire
mcmire committed Jun 7, 2024
commit 54f60dcf584afa099189f275e2faff97c3e8c33c
4 changes: 2 additions & 2 deletions .github/workflows/publish-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
fail-on-cache-miss: true
- name: Dry Run Publish
# omit npm-token token to perform dry run publish
uses: MetaMask/action-npm-publish@v4
uses: MetaMask/action-npm-publish@v5
Copy link
Member

@Gudahtt Gudahtt Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Was there a reason for updating to v5 in this PR? Seems like a good idea but it wasn't obvious how that related to the Yarn v4 update.

Copy link
Contributor Author

@mcmire mcmire Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, good question, I didn't highlight this. Yarn v4 now requires passing an --all option to yarn workspaces foreach if you want to iterate over all packages in the workspace. action-npm-publish v4 didn't pass this option, but v5 does now: MetaMask/action-npm-publish@f861a2b

Copy link
Member

@Gudahtt Gudahtt Jun 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, makes sense!

with:
slack-webhook-url: ${{ secrets.SLACK_WEBHOOK_URL }}
subteam: S042S7RE4AE # @metamask-npm-publishers
Expand Down Expand Up @@ -101,7 +101,7 @@ jobs:
key: ${{ github.sha }}
fail-on-cache-miss: true
- name: Publish
uses: MetaMask/action-npm-publish@v4
uses: MetaMask/action-npm-publish@v5
with:
npm-token: ${{ secrets.NPM_TOKEN }}
env:
Expand Down