-
-
Notifications
You must be signed in to change notification settings - Fork 258
Upgrade to TypeScript v5.0 and set module{,Resolution} option to Node16
#3645
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
61 commits
Select commit
Hold shift + click to select a range
bf479b4
Bump TypeScript to `~5.0.4`
MajorLift 5084b8f
Set tsconfig `module`, `moduleResolution` options to `NodeNext`
MajorLift 1d77aa8
'yarn build:types' works
mcmire dd45b15
Apply yarn patches to replace superstruct imports with `@metamask/sup…
MajorLift 6e73a35
Linter fixes
MajorLift cad9be5
Bump TypeScript to `~5.0.4` in remaining packages
MajorLift a014d03
Fix missing yarn patch for `@metamask/keyring-api@^6.1.1`
MajorLift 1d8944a
Replace `multiformats` import with dynamic import, and convert method…
MajorLift c509fb4
Apply `--experimental-vm-modules` flag to jest test scripts to enable…
MajorLift 94ddd59
Update yarn constraints to apply `--experimental-vm-modules` flag to …
MajorLift c21f3f9
Remove `EthErc4337Method` enum usage due to upstream removal
MajorLift 1b6fec9
Apply yarn patch to new `@metamask/keyring-api` version
MajorLift 8a5c556
Linter fixes
MajorLift 853340d
Linter fixes
MajorLift aceb333
Bump dependencies requiring new releases to latest
MajorLift fc9c89f
Apply yarn patch for `@metamask/snaps-sdk` `^4.4.1`
MajorLift 6af5113
Apply yarn patch for `@metamask/snaps-utils` `^7.4.1`
MajorLift dc29903
Update yarn resolutions for dependencies affected by `superstruct` issue
MajorLift ac77a7b
Bump `@metamask/utils` from `^8.3.0` to `^8.5.0` in all packages
MajorLift a8b8a0d
Bump out-of-sync dependencies
MajorLift b35692d
Force yarn resolution for `@metamask/provider` to `17.1.0` release ca…
MajorLift 4cfe39a
Update resolutions for new releases
MajorLift 468f6d3
Merge branch 'main' into 231208-typescript-module-resolution
MajorLift cbf9e38
Remove unused yarn resolution for `superstruct`
MajorLift 55a507e
Remove yarn resolutions for `@metamask/{providers,snaps-registry}`
MajorLift 90962b5
[assets-controllers] Bump `@metamask/abi-utils` from `^2.0.2` to `^2.…
MajorLift 7760b3d
Add yarn patches for `@metamask/snaps-{sdk,utils}` removing `superstr…
MajorLift cbbd428
Merge branch 'main' into 231208-typescript-module-resolution
MajorLift a67c547
Fix subpath imports, which are no longer supported unless specified i…
MajorLift 864ec65
Bump `@metamask/utils` from `^8.5.0` to `^9.0.0`
MajorLift 9bbd37d
Force yarn resolution for `@metamask/utils` to `9.0.0`
MajorLift bf5d240
Bump `@metamask/rpc-errors` from `^6.2.1` to `^6.3.1`
MajorLift 2ca4265
Revert "Force yarn resolution for `@metamask/utils` to `9.0.0`"
MajorLift cb032c2
Bump `@metamask/chain-api` from `^0.0.1` to `^0.1.0`
MajorLift 07fbffc
Fix lockfile
MajorLift d9160c6
Merge branch 'main' into 231208-typescript-module-resolution
MajorLift 1a1b497
Merge branch 'main' into 231208-typescript-module-resolution
MajorLift 9ddd7e6
Replace yarn resolutions for `@metamask/snaps-{sdk,utils}` with wip b…
MajorLift 261638a
Remove unnecessary yarn resolution for `@metamask/eth-snap-keyring`
MajorLift e0ff883
Remove unused yarn patch files
MajorLift 9226a38
Remove unused entry from .depcheckrc.yml
MajorLift 555ec31
Update jest.config.scripts.js
MajorLift 6defd76
build(tsc): Set `moduleResolution` to `node16`
MajorLift 99abde6
Merge branch 'main' into 231208-typescript-module-resolution
MajorLift 0910cea
Dedupe lockfile
MajorLift f28ecd5
Merge branch 'main' into 231208-typescript-module-resolution
MajorLift 67f1484
Merge branch 'main' into 231208-typescript-module-resolution
MajorLift f37057c
Merge branch 'main' into 231208-typescript-module-resolution
MajorLift b0fd3b8
Remove unused `ts-expect-error` directive
MajorLift b8f8c52
Update yarn resolution for snaps monorepo and fix `@metamask/provider…
MajorLift 87af678
Merge branch 'main' into 231208-typescript-module-resolution
MajorLift f2f7d1f
Remove yarn resolution for `@metamask/providers` `17.0.0`
MajorLift 6f69db3
Merge branch 'main' into 231208-typescript-module-resolution
MajorLift 27ba6c5
Bump `@metamask/keyring-api` from `^8.0.0` to `^8.0.1`
MajorLift b0c81fb
Merge branch 'main' into 231208-typescript-module-resolution
MajorLift 09b29ca
Update yarn resolutions for `snaps-{sdk,utils}`
MajorLift de15ab3
Merge branch 'main' into 231208-typescript-module-resolution
MajorLift 59fe394
Bump `@metamask/snaps-sdk` to `^6.1.0`, `@metamask/snaps-utils` to `^…
MajorLift 6b0075d
Merge branch 'main' into 231208-typescript-module-resolution
MajorLift f50b209
Set yarn resolution for `@metamask/[email protected]` dependency `@meta…
MajorLift 5f0b948
Merge branch 'main' into 231208-typescript-module-resolution
MajorLift File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix subpath imports, which are no longer supported unless specified i…
…n the upstream package's package.json exports field
- Loading branch information
commit a67c547805fe67045deff8dfbd2f8784f20b0db0
There are no files selected for viewing
16 changes: 8 additions & 8 deletions
16
packages/assets-controllers/src/AccountTrackerController.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With the
Node{16,Next}option, subpath imports are no longer supported unless explicitly defined in the source package manifest's "exports" field.Here, an import from
@metamask/accounts-controller/src/tests/mocksneeded to be replaced with a relative path import.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I'm not sure how this slipped through the cracks! Makes sense.