Fix transaction status incorrectly set to dropped, submitted, or failed#3676
Merged
matthewwalsh0 merged 8 commits intomainfrom Dec 19, 2023
Merged
Conversation
Check state for polling when changing network.
13 tasks
vinistevam
previously approved these changes
Dec 18, 2023
vinistevam
previously approved these changes
Dec 18, 2023
dbrans
previously approved these changes
Dec 18, 2023
packages/transaction-controller/src/helpers/PendingTransactionTracker.ts
Outdated
Show resolved
Hide resolved
18c0924
…ter-network-change
Remove duplication.
vinistevam
approved these changes
Dec 19, 2023
…ter-network-change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Multiple fixes following the full release of the core
TransactionControllerin the extension:PendingTransactionTracker, look at wallet transactions only from the current chain.nullor invalidstatus.Changelog
@metamask/transaction-controllerdroppedstatus detection by ignoring transactions on other chains.r,s, andvvalues even if zero.statusis explicitly0x0.Checklist