Skip to content

deps(transactions-controller): eth-method-registry@^1.1.0->^3.0.0#3688

Merged
legobeat merged 1 commit intoMetaMask:mainfrom
legobeat:deps-eth-method-registry
Jan 4, 2024
Merged

deps(transactions-controller): eth-method-registry@^1.1.0->^3.0.0#3688
legobeat merged 1 commit intoMetaMask:mainfrom
legobeat:deps-eth-method-registry

Conversation

@legobeat
Copy link
Contributor

@legobeat legobeat commented Dec 20, 2023 •
edited
Loading

Explanation

  • Removes dependency on legacy ethjs packages and deprecated version of xhr2
    • Prepare for removing dependency on babel-runtime

References

Breaking changes in the updated package part of this update

Changelog

@metamask/transactions-controller

  • CHANGED: Update @metamask/eth-method-registry from ^1.1.0 to ^3.0.0

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate

@legobeat legobeat added the dependencies Pull requests that update a dependency file label Dec 20, 2023
@legobeat legobeat force-pushed the deps-eth-method-registry branch from 420ec72 to 878c4d7 Compare December 20, 2023 04:21
legobeat
legobeat commented Dec 20, 2023
View reviewed changes
@legobeat legobeat force-pushed the deps-eth-method-registry branch from 878c4d7 to 0409f4e Compare December 20, 2023 04:24
@legobeat legobeat marked this pull request as ready for review December 20, 2023 04:25
@legobeat legobeat requested a review from a team as a code owner December 20, 2023 04:25
@legobeat legobeat requested review from kumavis and rekmarks December 20, 2023 04:25
@legobeat legobeat force-pushed the deps-eth-method-registry branch from 0409f4e to 3752652 Compare January 3, 2024 11:46
@legobeat legobeat requested review from a team January 3, 2024 11:54
@legobeat legobeat force-pushed the deps-eth-method-registry branch from 3752652 to b7114a4 Compare January 3, 2024 19:12
Gudahtt
Gudahtt approved these changes Jan 3, 2024
View reviewed changes
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@legobeat legobeat merged commit 865532b into MetaMask:main Jan 4, 2024
@legobeat legobeat mentioned this pull request Feb 7, 2024
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@kumavis kumavis Awaiting requested review from kumavis

@rekmarks rekmarks Awaiting requested review from rekmarks

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@legobeat @Gudahtt