Skip to content

Release 161.0.0 #4413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ccharly merged 33 commits into from
Jun 12, 2024
Merged

Release 161.0.0 #4413

Changes from 1 commit
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
233b705
Initialize Release 161.0.0
ccharly Jun 12, 2024
25a6c51
Update Release 161.0.0
ccharly Jun 12, 2024
7beeba9
chore: update accounts-controller CHANGELOG.md
ccharly Jun 12, 2024
9f61b2b
chore: update assets-controller CHANGELOG.md
ccharly Jun 12, 2024
dc93145
chore: update chain-controller CHANGELOG.md
ccharly Jun 12, 2024
1215152
chore: update keyring-controller CHANGELOG.md
ccharly Jun 12, 2024
b57a7f8
chore: update selected-network-controller CHANGELOG.md
ccharly Jun 12, 2024
ec719c8
chore: update transaction-controller CHANGELOG.md
ccharly Jun 12, 2024
e631ca5
chore: yarn constraints --fix
ccharly Jun 12, 2024
dc2a863
chore: update changelogs after for constraints fixes
ccharly Jun 12, 2024
43da8a8
chore: yarn.lock
ccharly Jun 12, 2024
c3d89d6
chore: fix changelog for assets-controllers
ccharly Jun 12, 2024
009d5b8
chore: update changelog for transaction-controller
ccharly Jun 12, 2024
ddeef9d
chore: update changelog for keyring-controller
ccharly Jun 12, 2024
a7710db
chore: update assets-controllers CHANGELOG.md
ccharly Jun 12, 2024
faa8750
chore: update assets-controllers CHANGELOG.md
ccharly Jun 12, 2024
b7fdc16
fix: fix assets-controllers CHANGELOG.md
ccharly Jun 12, 2024
b998da8
chore: re-categorized some changes in assets-controllers CHANGELOG.md
ccharly Jun 12, 2024
4cd1d52
chore: update changelog entry for assets-controllers CHANGELOG.md
ccharly Jun 12, 2024
8b7ae3d
chore: update changelog entry for assets-controllers CHANGELOG.md
ccharly Jun 12, 2024
451d356
chore: re-categorized some changes in assets-controllers CHANGELOG.md
ccharly Jun 12, 2024
b6bc2d9
chore: update assets-controllers CHANGELOG.md
ccharly Jun 12, 2024
18a8a48
chore: update assets-controllers CHANGELOG.md
ccharly Jun 12, 2024
13d91ae
chore: initial release for chain-controller
ccharly Jun 12, 2024
c9a6139
chore: update entries for #4314
ccharly Jun 12, 2024
37bc182
chore: update assets-controllers CHANGELOG.md
ccharly Jun 12, 2024
f71d036
chore: update assets-controllers CHANGELOG.md
ccharly Jun 12, 2024
374c25b
chore: update transaction-controller CHANGELOG.md
ccharly Jun 12, 2024
83c5a8f
chore: update changelog for transaction-controller
ccharly Jun 12, 2024
f273f6e
chore: update changelog for assets-controller
ccharly Jun 12, 2024
347751f
chore: update changelog for transaction-controller
ccharly Jun 12, 2024
16aed63
chore: update changelog for keyring-controller
ccharly Jun 12, 2024
f15f107
Merge branch 'main' into release/161.0.0
ccharly Jun 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: update assets-controllers CHANGELOG.md 
Co-authored-by: Jongsun Suh <[email protected]>
  • Loading branch information
@ccharly @MajorLift
ccharly and MajorLift authored Jun 12, 2024
commit faa8750c3158ed3f334671af989b3d739f8d5d5f
15 changes: 8 additions & 7 deletions packages/assets-controllers/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,17 +11,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Added

- Added `Mutex` lock in the `updateNftMetadata` function ([#4325](https://github.com/MetaMask/core/pull/4325))
- **BREAKING:** Add `messenger` as a constructor option for `AccountTrackerController` ([#4225](https://github.com/MetaMask/core/pull/4225))
(https://github.com/MetaMask/core/pull/4225))
- Add `AccountTrackerControllerMessenger` type
Copy link
Contributor

@MajorLift MajorLift Jun 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah looks like this belongs under line 14.

Leaving this comment as reference to be fixed by a future PR covering AccountTrackerController.

- `NftController` now allows `AccountsController:getAccount`, `AccountsController:getSelectedAccount` as messenger actions and subscribes to the `AccountsController:selectedEvmAccountChange` messenger event ([#4221](https://github.com/MetaMask/core/pull/4221))
Copy link
Contributor

@mcmire mcmire Jun 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saying that the controller allows the actions/events is a bit inaccurate; it would be better to say that the messenger that the controller takes must allow these actions/events. If the consumer isn't doing that currently and upgrades this package, then they will see a type and runtime error when the NftController constructor is run, so that makes this a breaking change:

Suggested change
- `NftController` now allows `AccountsController:getAccount`, `AccountsController:getSelectedAccount` as messenger actions and subscribes to the `AccountsController:selectedEvmAccountChange` messenger event ([#4221](https://github.com/MetaMask/core/pull/4221))
- **BREAKING:** The `NftController` messenger must now allow `AccountsController:getAccount` and `AccountsController:getSelectedAccount` as messenger actions and `AccountsController:selectedEvmAccountChange` as a messenger event ([#4221](https://github.com/MetaMask/core/pull/4221))

Copy link
Contributor Author

@ccharly ccharly Jun 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initially we had that BREAKING prefix yes, but after discussing with @MajorLift, I understood this was not considered a "real" breaking changes. Anyway, I do agree with your suggestion, so let's re-add it. :)

Copy link
Contributor

@MajorLift MajorLift Jun 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with Elliot's description of the desired behavior, but it doesn't appear that we have type or runtime error guardrails in controller constructor for subtype messengers. Passing in messengers with incomplete or never allowlists into controller constructors seems to work fine.

Runtime errors are thrown, but only when call and subscribe/unsubscribe (or more accurately #isAllowedAction, #isAllowedEvent) is being invoked for the omitted actions/events.

I'll experiment with this a bit more in the test files since I might just be doing something wrong.

Edit: Created a base-controller ticket for this #4414

- `NftDetectionController` now allows `AccountsController:getSelectedAccount` as a messenger action ([#4221](https://github.com/MetaMask/core/pull/4221))
- Add `Mutex` lock in the `updateNftMetadata` function ([#4325](https://github.com/MetaMask/core/pull/4325))
- Token price API support for mantle network ([#4376](https://github.com/MetaMask/core/pull/4376))

### Changed

- **BREAKING:** `NftController` constructor argument `selectedAddress` has been removed. ([#4221](https://github.com/MetaMask/core/pull/4221))
- **BREAKING:** `NftController` now requires `AccountsController:get{Account,SelectedAccount}` messenger actions. ([#4221](https://github.com/MetaMask/core/pull/4221))
- **BREAKING:** `NftController` now requires `AccountsController:selectedEvmAccountChange` event. ([#4221](https://github.com/MetaMask/core/pull/4221))
- **BREAKING:** `NftDetectionController` now requires `AccountsControlelr:getSelectedAccount` messenger actions. ([#4221](https://github.com/MetaMask/core/pull/4221))
- **BREAKING:** `AccountTrackerController` now requires a controller messenger ([#4225](https://github.com/MetaMask/core/pull/4225))
- **BREAKING:** Removed `getIdentities`, `getSelectedAddress` and `onPreferencesStateChange` from the constructor arguments of the `AccountTrackerController` ([#4225](https://github.com/MetaMask/core/pull/4225))
- **BREAKING:** Bump dependency and peer dependency `@metamask/accounts-controller` to `^17.0.0` ([#4413](https://github.com/MetaMask/core/pull/4413))
- Upgrade `TokenRatesController` to `BaseControllerV2` ([#4314](https://github.com/MetaMask/core/pull/4314))
- Update Nft controllers to use `selectedAccountId` instead of `selectedAddress` ([#4221](https://github.com/MetaMask/core/pull/4221))
Expand All @@ -32,6 +31,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Removed

- **BREAKING:** Remove `NftController` constructor options `selectedAddress`. ([#4221](https://github.com/MetaMask/core/pull/4221))
- **BREAKING:** Remove `AccountTrackerController` constructor options `getIdentities`, `getSelectedAddress` and `onPreferencesStateChange` ([#4225]
- Remove `value` from price API responses ([#4364](https://github.com/MetaMask/core/pull/4364))

### Fixed
Expand Down