Fixed SafeEventEmitterProvider invalid default params

[kanthesha]

Explanation

The SafeEventEmitterProvider is failing to send net_version requests correctly because it's using an empty object as the default params when none are provided.

While some methods do use an object for params, the vast majority use an array instead. Passing an empty object as the params for a method that has array parameters can result in failure (as is the case for net_version).

References

• Fixes [safe-event-emitter-provider] Invalid default params #4595

Changelog

@metamask/eth-json-rpc-provider

• FIXED: The default value for params in the request has been replaced from empty object to an empty array

Checklist

• I've updated the test suite for new or updated code as appropriate
• I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
• I've highlighted breaking changes using the "BREAKING" category above as appropriate

[Gudahtt]

I think it would be safer to omit rather than using any default, see here for details

[Gudahtt]

Hmm, this return type is invalid. The Record<never, never> does not belong here, no possible return value is represented by that type. Yet if we remove it, we get the type error I referenced in the other thread. How odd.

Maybe we can fix it in a later PR, since it's a pre-existing issue. This type is used later in this file as well.

[Gudahtt]

LGTM!