Skip to content

Conversation

@brad-decker
Copy link
Contributor

This PR does the following:

  1. renames 'getIsMainnet' to 'getCurrentNetworkLegacyGasAPICompatibility'
  2. adds a 'getChainId' argument to the controller
  3. adds support for providing API endpoint URLs int the controller
  4. Supports replacing <chain_id> in provided URLs.

Goals:

  1. Presumably if the API meets the spec put together in our mock data, we can swap out URLs without rebuilding/re-releasing
  2. Support networks like Binance that has its own gas estimation API.

@brad-decker brad-decker requested a review from a team as a code owner July 6, 2021 19:08
Copy link
Member

@wachunei wachunei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brad-decker brad-decker force-pushed the add-more-configuration-options branch from 213518e to 2e705f4 Compare July 6, 2021 19:44
@brad-decker brad-decker requested a review from wachunei July 6, 2021 19:59
@brad-decker brad-decker merged commit cc471dc into draft-gasfee-controller Jul 6, 2021
@brad-decker brad-decker deleted the add-more-configuration-options branch July 6, 2021 20:25
brad-decker added a commit that referenced this pull request Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants