feat: support external sign transactions#5604
Merged
matthewwalsh0 merged 3 commits intomainfrom Apr 8, 2025
Merged
Conversation
matthewwalsh0
changed the base branch from
main
to
feat/is-atomic-batch-supported
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
OGPoyraz
previously approved these changes
Apr 8, 2025
matthewwalsh0
force-pushed
the
feat/is-atomic-batch-supported
branch
from
88ffa32 to
6a29cee
Compare
pedronfigueiredo
previously approved these changes
Apr 8, 2025
matthewwalsh0
dismissed stale reviews from pedronfigueiredo and OGPoyraz
The base branch was changed.
Skip signing if external sign. Skip dropped checks if external sign.
matthewwalsh0
force-pushed
the
feat/transaction-external-sign
branch
from
7f6d1f4 to
b5f94e2
Compare
OGPoyraz
approved these changes
Apr 8, 2025
matallui
added a commit
that referenced
this pull request
Apr 9, 2025
* main: Fix unmocked block tracker warning in NetworkController tests (#5289) ci: GH action to remind developers to add release notes in CHANGELOG.md (#5620) Release 355.0.0 (#5619) Release 354.0.0 (#5615) fix: Update origin in Snap requests (#5616) Release/353.0.0 (#5612) refactor(accounts-controller): use type-cast instead of `@ts-expect-error` (#5568) feat: support external sign transactions (#5604) feat: extend isAtomicBatchSupported result (#5600) fix: Rename `enableTxParamsGasFeeUpdates` to `isAutomaticGasFeeUpdateEnabled` and also callback (#5602) Release/352.0.0 (#5608) feat: STAKE-1005: refresh staking data when staking txs are confirmed (#5607)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Support transactions that are signed externally, such as delegations, using a new
isExternalSignproperty that disables nonce generation and signing via theKeyringController.References
Fixes #4596 #4597
Checklist