Skip to content

fix(multichain-account-service)!: wait for Snap platform to be ready #7266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ccharly wants to merge 6 commits into
base: main
Choose a base branch
from
+361 −123
Open

fix(multichain-account-service)!: wait for Snap platform to be ready #7266

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
05e7530
feat(multichain-account-service): wait for Snap platform to be ready …
ccharly Nov 28, 2025
6e4c4a6
refactor: enforce Snap platform check before any provider calls
ccharly Nov 28, 2025
5ac68b5
chore: cosmetic
ccharly Nov 28, 2025
d01b4a1
refactor: remove extra ensureSnapPlatformIsReady call
ccharly Nov 28, 2025
1b69b3a
refactor: move reset state to setup function
ccharly Nov 28, 2025
0ccef45
chore: update changelog
ccharly Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: move reset state to setup function
  • Loading branch information
@ccharly
ccharly committed Nov 28, 2025
commit 1b69b3ae325d1baf1ce17156b174b126fc1841d2
8 changes: 4 additions & 4 deletions packages/multichain-account-service/src/providers/SnapAccountProvider.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,6 +189,10 @@ const setup = ({
),
);

// We reset this state, since it's a static field, so each tests would start
// with a fresh state.
MockSnapAccountProvider.resetEnsureSnapPlatformIsReady();

const serviceMessenger = getMultichainAccountServiceMessenger(messenger);
const config = {
...(maxConcurrency !== undefined && { maxConcurrency }),
Expand All @@ -211,10 +215,6 @@ const setup = ({
};

describe('SnapAccountProvider', () => {
beforeEach(() => {
MockSnapAccountProvider.resetEnsureSnapPlatformIsReady();
});

describe('constructor default parameters', () => {
const mockMessenger = {
call: jest.fn().mockResolvedValue({}),
Expand Down
Loading