Skip to content

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Dec 3, 2025

Explanation

Update all ESLint config packages from v14.x to v15. These updates introduce some helpful new rules, and loosen/disable a few rules that were causing us problems.

Details here: MetaMask/eslint-config#431

Most of the changes are due to the newly introduced import-x/consistent-type-specifier-style rule. The majority of the changes were from running yarn lint:fix, but I did make one commit to consolidate some duplicate import lines that the auto-fixer added.

References

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Bumps ESLint config packages to v15 and updates imports across the repo to the new import type { ... } style, with minor ESLint rule tweaks (jsdoc) and lockfile updates.

  • Tooling/Config:
    • Upgrade @metamask/eslint-config* packages to v15 in package.json and yarn.lock.
    • Tweak eslint.config.mjs: keep jsdoc/require-jsdoc and related jsdoc rules disabled; update comments.
  • Codebase-wide refactor (lint autofix):
    • Conform to import-x/consistent-type-specifier-style: switch to import type { ... } for type-only imports; separate value vs type imports across packages.
    • Minor import consolidations/reorders in tests and sources.
  • No functional changes: Only lint-driven import/style updates.

Written by Cursor Bugbot for commit 735caaf. This will update automatically on new commits. Configure here.

@socket-security
Copy link

socket-security bot commented Dec 3, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updated@​metamask/​eslint-config-jest@​14.1.0 ⏵ 15.0.099 +110079 +191 +4100
Updated@​metamask/​eslint-config@​14.1.0 ⏵ 15.0.099 +110085 +191 +4100
Updated@​metamask/​eslint-config-nodejs@​14.0.0 ⏵ 15.0.099 +11008689 +8100
Updated@​metamask/​eslint-config-typescript@​14.1.0 ⏵ 15.0.09910086 +191 +4100

View full report

Update all ESLint config packages from v14.x to v15. These updates introduce
some helpful new rules, and loosen/disable a few rules that were causing us
problems.

Details here: MetaMask/eslint-config#431
@Gudahtt Gudahtt force-pushed the update-eslint-config-v15 branch from a40310f to 735caaf Compare December 3, 2025 20:01
@Gudahtt Gudahtt marked this pull request as ready for review December 3, 2025 20:17
@Gudahtt Gudahtt requested review from a team as code owners December 3, 2025 20:17
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt merged commit b3fd010 into main Dec 3, 2025
299 checks passed
@Gudahtt Gudahtt deleted the update-eslint-config-v15 branch December 3, 2025 20:45
georgewrmarshall added a commit to MetaMask/metamask-design-system that referenced this pull request Dec 4, 2025
georgewrmarshall added a commit to MetaMask/metamask-design-system that referenced this pull request Dec 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants