Skip to content

chore: integrate storageService with tokenListController #7413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sahar-fehri wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

chore: integrate storageService with tokenListController #7413

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d19c31d
chore: integrate storageService with tokenListController
sahar-fehri Dec 9, 2025
bffca81
chore: lint
sahar-fehri Dec 9, 2025
339ad11
fix: ut
sahar-fehri Dec 9, 2025
ec25b72
fix: lint
sahar-fehri Dec 9, 2025
bff906c
Merge branch 'main' into chore/integrate-storage-service-with-tokenLi…
sahar-fehri Dec 10, 2025
9c9078b
fix: changelog
sahar-fehri Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: integrate storageService with tokenListController
  • Loading branch information
@sahar-fehri
sahar-fehri committed Dec 9, 2025
commit d19c31d460d9f3affb074278d527c91f86d15502
1 change: 1 addition & 0 deletions packages/assets-controllers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,6 +78,7 @@
"@metamask/snaps-controllers": "^14.0.1",
"@metamask/snaps-sdk": "^9.0.0",
"@metamask/snaps-utils": "^11.0.0",
"@metamask/storage-service": "^0.0.0",
"@metamask/transaction-controller": "^62.5.0",
"@metamask/utils": "^11.8.1",
"@types/bn.js": "^5.1.5",
Expand Down
1 change: 0 additions & 1 deletion packages/assets-controllers/src/TokenListController.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1069,7 +1069,7 @@
state: existingState,
});
expect(controller.state).toStrictEqual(existingState);
controller.clearingTokenListData();

Check failure on line 1072 in packages/assets-controllers/src/TokenListController.test.ts

View workflow job for this annotation

GitHub Actions / Lint, build, and test / Lint (22.x) 

Promises must be awaited, end with a call to .catch, end with a call to .then with a rejection handler or be explicitly marked as ignored with the `void` operator

expect(controller.state.tokensChainsCache).toStrictEqual({});

Expand Down Expand Up @@ -1331,7 +1331,6 @@
).toMatchInlineSnapshot(`
Object {
"preventPollingOnNetworkRestart": false,
"tokensChainsCache": Object {},
}
`);
});
Expand Down
Loading
Loading