Skip to content

feat: Adding requestId field to dapp confirmations #7415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jpuri wants to merge 13 commits into
base: main
Choose a base branch
from
+41 −0
Open

feat: Adding requestId field to dapp confirmations #7415

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
2cfdb03
Adding requestId field to dapp confirmations
jpuri Dec 9, 2025
9abf1e0
Merge branch 'main' into request_id_support
jpuri Dec 9, 2025
665775d
update
jpuri Dec 9, 2025
71b0332
Merge branch 'request_id_support' of https://github.com/MetaMask/core…
jpuri Dec 9, 2025
c645831
update
jpuri Dec 9, 2025
d58f206
Merge branch 'main' into request_id_support
jpuri Dec 9, 2025
35a452d
Merge branch 'main' into request_id_support
jpuri Dec 9, 2025
c75349a
update
jpuri Dec 10, 2025
741816f
Merge branch 'request_id_support' of https://github.com/MetaMask/core…
jpuri Dec 10, 2025
ddd24c9
update
jpuri Dec 10, 2025
b7ed73e
Merge branch 'main' into request_id_support
jpuri Dec 10, 2025
a209dc8
update
jpuri Dec 10, 2025
e854e88
Merge branch 'request_id_support' of https://github.com/MetaMask/core…
jpuri Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update
  • Loading branch information
@jpuri
jpuri committed Dec 9, 2025
commit 665775dad8cb0a6615f250d7ebd951e84fe141e8
2 changes: 2 additions & 0 deletions packages/eip-5792-middleware/src/hooks/processSendCalls.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,7 @@ describe('EIP-5792', () => {
from: SEND_CALLS_MOCK.from,
networkClientId: NETWORK_CLIENT_ID_MOCK,
origin: ORIGIN_MOCK,
requestId: '1',
securityAlertId: expect.any(String),
transactions: [
{ params: SEND_CALLS_MOCK.calls[0] },
Expand Down Expand Up @@ -237,6 +238,7 @@ describe('EIP-5792', () => {
batchId: expect.any(String),
networkClientId: 'test-client',
origin: 'test.com',
requestId: '1',
securityAlertResponse: {
securityAlertId: expect.any(String),
},
Expand Down