Skip to content

chore(lint): Fix suppressed ESLint errors in network-controller package #7445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Mrtenz wants to merge 3 commits into
base: main
Choose a base branch
from
+376 −371
Open

chore(lint): Fix suppressed ESLint errors in network-controller package #7445

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f5576d2
Fix suppressed ESLint errors in `network-controller` package
Mrtenz Dec 11, 2025
de67764
Fix some types
Mrtenz Dec 11, 2025
8370d75
Revert change
Mrtenz Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Revert change
  • Loading branch information
@Mrtenz
Mrtenz committed Dec 11, 2025
commit 8370d752d2e8bef817448ae3c36851f802359f8f
6 changes: 4 additions & 2 deletions packages/network-controller/tests/network-client/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,9 @@ function mockRpcCall({
const httpStatus =
(typeof response === 'object' &&
'httpStatus' in response &&
response.httpStatus) ??
// Using nullish coalescing here breaks the tests.
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
response.httpStatus) ||
200;

/* @ts-expect-error The types for Nock do not include `basePath` in the interface for Nock.Scope. */
Expand Down Expand Up @@ -597,7 +599,7 @@ export async function withNetworkClient<Type>(
}

type BuildMockParamsOptions = {
blockParam: Json;
blockParam?: Json;
blockParamIndex: number;
};

Expand Down
Loading