fix: include authorizations in nonce calculation #7446
+115
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
When determining the next transaction nonce, factor any
authorizationListnonces on pending type-4 transactions.References
Related to #23881
Checklist
Note
Include EIP-7702 authorizationList nonces in nonce tracking and ignore transactions without a nonce, with tests and changelog updated.
src/utils/nonce.ts)authorizationListnonces when formatting transactions for the nonce tracker.txParams.nonce; continue excluding transfers and user operations.flatMapto emit one entry per base nonce and each authorization nonce.src/utils/nonce.test.ts)authorizationListnonces.packages/transaction-controller/CHANGELOG.md)Written by Cursor Bugbot for commit d203763. This will update automatically on new commits. Configure here.