chore: batch account creation #7467
Draft
+236
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This batches some calls during account creation after SRP import. It reduced time it took from ~35s to ~9s on my device for SRP with ~250 accounts.
I am not sure if this is worth merging because of #6654
References
Checklist
Note
Batches EVM account discovery/creation and debounces wallet/group syncs to cut redundant vault updates during large imports.
#pendingWalletSyncsand#pendingGroupSyncs; replace immediatewallet.sync()/group.sync()on account add with queued flush via#scheduleSync()and#flushSyncs().maxGroupIndexaccordingly.findActiveAccountCount(checks activity viaeth_getTransactionCount),bulkCreateAccounts(single keyring write), and internal#createAccountsBatchhelper; expose address/tx-count helpers for discovery flow.Written by Cursor Bugbot for commit a9466cf. This will update automatically on new commits. Configure here.