Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: MetaMask/create-release-branch
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Choose a base ref
...
head repository: MetaMask/create-release-branch
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: add-first-cut
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 13 commits
  • 53 files changed
  • 1 contributor

Commits on Jul 7, 2022

  1. Upgrade to Yarn v3

    This is copied from the module template. See here for more context:
    
    <MetaMask/metamask-module-template#108>
    mcmire committed Jul 7, 2022
    Configuration menu
    Copy the full SHA
    64c12bf View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2022

  1. Adjust ESLint rules

    * Assume that all JavaScript and TypeScript files are run in a Node
      context, and allow `process.env` to be accessed and `process.exit()`
      to be called freely.
    * Tweak rules for blank lines. Currently we check that blank lines are
      inserted in between:
    
      * A directive prologue (like `use strict`) and anything else (except
        another directive prologue)
      * A multiline block-like statement (e.g. `if`, `while`, IIFEs, etc.)
        and a multiline expressions (e.g. multiline function calls)
      * A multiline block-like statement (e.g. `if`, `while`, IIFEs, etc.)
        and another multiline block-like statement
      * A multiline expression and a multiline block-like statement
      * A multiline expression and another multiline expression
    
      The issue is that enforcing line breaks in between multiline function
      or method calls makes organizing big integration tests more difficult.
      At the same time, multiline `if` statements more often than not
      involve some kind of complexity that would be unreadable smooshed up
      against some other code, so this commit also enforces empty line
      breaks around any kind of such statement.
    mcmire committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    7f908ff View commit details
    Browse the repository at this point in the history
  2. Upgrade Jest to v28

    Jest 28 enables use of the `jest.mocked` utility which is copied from
    `ts-jest` and which gives you a correctly-typed version of a function
    you've mocked via `jest.mock`.
    mcmire committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    ea0a623 View commit details
    Browse the repository at this point in the history
  3. Use Babel for Jest coverage provider

    v8 isn't quite reliable when using Node 14 for development (it has too
    many false negatives). We can consider changing this back if/when we
    switch to Node 16 or later, but for now we will stick to Babel.
    mcmire committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    91ee655 View commit details
    Browse the repository at this point in the history
  4. wip

    mcmire committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    7466b3f View commit details
    Browse the repository at this point in the history
  5. wip

    mcmire committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    a5dd9f4 View commit details
    Browse the repository at this point in the history
  6. tests working again

    mcmire committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    28d281a View commit details
    Browse the repository at this point in the history
  7. update docs

    mcmire committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    7a150ea View commit details
    Browse the repository at this point in the history
  8. wip jest

    mcmire committed Jul 11, 2022
    Configuration menu
    Copy the full SHA
    5ef2d60 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2022

  1. wip tests

    mcmire committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    ee3c3ac View commit details
    Browse the repository at this point in the history
  2. Backfill a bunch of unit tests

    Remaining tests:
    
    * Remaining monorepo-workflow-utils tests
    * package-utils
    * project-utils
    * workflow-utils
    
    Also maybe move ReleasePlan and PackageReleasePlan into
    release-plan-utils? Or move to something else?
    mcmire committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    a350ab3 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. cleaning up tests a bit

    mcmire committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    a0d3d19 View commit details
    Browse the repository at this point in the history
  2. More tests

    Remaining:
    
    * package-manifest-utils
    * project-utils
    * release-specification-utils
    * semver-utils
    * workflow-utils
    
    Also, change the root package version number so it looks like
    YYYYMMDD.BUILD_NUMBER.0 instead of YEAR.MONTH.DAY-BUILD_NUMBER.
    mcmire committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    b39daf4 View commit details
    Browse the repository at this point in the history
Loading