-
-
Notifications
You must be signed in to change notification settings - Fork 5
Permalink
Choose a base ref
{{ refName }}
default
Choose a head ref
{{ refName }}
default
Checking mergeability…
Don’t worry, you can still create the pull request.
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
base repository: MetaMask/create-release-branch
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: main
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
...
head repository: MetaMask/create-release-branch
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: add-first-cut
Could not load branches
Nothing to show
Loading
Could not load tags
Nothing to show
{{ refName }}
default
Loading
- 13 commits
- 53 files changed
- 1 contributor
Commits on Jul 7, 2022
-
This is copied from the module template. See here for more context: <MetaMask/metamask-module-template#108>
Configuration menu - View commit details
-
Copy full SHA for 64c12bf - Browse repository at this point
Copy the full SHA 64c12bfView commit details
Commits on Jul 11, 2022
-
* Assume that all JavaScript and TypeScript files are run in a Node context, and allow `process.env` to be accessed and `process.exit()` to be called freely. * Tweak rules for blank lines. Currently we check that blank lines are inserted in between: * A directive prologue (like `use strict`) and anything else (except another directive prologue) * A multiline block-like statement (e.g. `if`, `while`, IIFEs, etc.) and a multiline expressions (e.g. multiline function calls) * A multiline block-like statement (e.g. `if`, `while`, IIFEs, etc.) and another multiline block-like statement * A multiline expression and a multiline block-like statement * A multiline expression and another multiline expression The issue is that enforcing line breaks in between multiline function or method calls makes organizing big integration tests more difficult. At the same time, multiline `if` statements more often than not involve some kind of complexity that would be unreadable smooshed up against some other code, so this commit also enforces empty line breaks around any kind of such statement.Configuration menu - View commit details
-
Copy full SHA for 7f908ff - Browse repository at this point
Copy the full SHA 7f908ffView commit details -
Jest 28 enables use of the `jest.mocked` utility which is copied from `ts-jest` and which gives you a correctly-typed version of a function you've mocked via `jest.mock`.
Configuration menu - View commit details
-
Copy full SHA for ea0a623 - Browse repository at this point
Copy the full SHA ea0a623View commit details -
Use Babel for Jest coverage provider
v8 isn't quite reliable when using Node 14 for development (it has too many false negatives). We can consider changing this back if/when we switch to Node 16 or later, but for now we will stick to Babel.
Configuration menu - View commit details
-
Copy full SHA for 91ee655 - Browse repository at this point
Copy the full SHA 91ee655View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7466b3f - Browse repository at this point
Copy the full SHA 7466b3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a5dd9f4 - Browse repository at this point
Copy the full SHA a5dd9f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28d281a - Browse repository at this point
Copy the full SHA 28d281aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7a150ea - Browse repository at this point
Copy the full SHA 7a150eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ef2d60 - Browse repository at this point
Copy the full SHA 5ef2d60View commit details
Commits on Jul 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for ee3c3ac - Browse repository at this point
Copy the full SHA ee3c3acView commit details -
Backfill a bunch of unit tests
Remaining tests: * Remaining monorepo-workflow-utils tests * package-utils * project-utils * workflow-utils Also maybe move ReleasePlan and PackageReleasePlan into release-plan-utils? Or move to something else?
Configuration menu - View commit details
-
Copy full SHA for a350ab3 - Browse repository at this point
Copy the full SHA a350ab3View commit details
Commits on Jul 13, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a0d3d19 - Browse repository at this point
Copy the full SHA a0d3d19View commit details -
Remaining: * package-manifest-utils * project-utils * release-specification-utils * semver-utils * workflow-utils Also, change the root package version number so it looks like YYYYMMDD.BUILD_NUMBER.0 instead of YEAR.MONTH.DAY-BUILD_NUMBER.
Configuration menu - View commit details
-
Copy full SHA for b39daf4 - Browse repository at this point
Copy the full SHA b39daf4View commit details
Loading
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff main...add-first-cut