Upgrade to Yarn v3 #108
Merged
Upgrade to Yarn v3 #108
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The package manager used has been upgraded from Yarn v1 to Yarn v3. All of the steps in the [migration guide][1] have been followed, so effectively everything should work the same way it did before. (Note that we are not using Plug'n'Play because it seems to prevent TypeScript from finding type definitions via `@types/*` packages.) The `setup` script has been replaced with a Yarn v3 plugin that will automatically run `allow-scripts` after install. This means that we can now use `yarn install` again as normal. This change was made to address a problem that happened when running `yarn setup` for the first time. Yarn 3 doesn't automatically install itself until you run the `install` command directly, so running the `setup` script before `install` would have thrown an error. This is non-obvious, so we chose to remove `setup` altogether. See [original source in `controllers`][2]. [1]: https://yarnpkg.com/getting-started/migration [2]: MetaMask/core@d92bec0 Co-authored-by: Mark Stacey <[email protected]>
mcmire
added a commit
to MetaMask/create-release-branch
that referenced
this pull request
Jul 7, 2022
This is copied from the module template. See here for more context: <MetaMask/metamask-module-template#108>
mcmire
added a commit
to MetaMask/create-release-branch
that referenced
this pull request
Jul 7, 2022
This is copied from the module template. See here for more context: <MetaMask/metamask-module-template#108>
mcmire
added a commit
to MetaMask/create-release-branch
that referenced
this pull request
Jul 12, 2022
This is copied from the module template. See here for more context: <MetaMask/metamask-module-template#108>
Gudahtt
approved these changes
Jul 20, 2022
Contributor
Author
|
🙏🏻 |
Gudahtt
added a commit
to MetaMask/browser-passworder
that referenced
this pull request
Oct 26, 2022
Yarn has been updated following the steps taken in the module template repository: MetaMask/metamask-module-template#108
Gudahtt
added a commit
to MetaMask/browser-passworder
that referenced
this pull request
Oct 26, 2022
Yarn has been updated following the steps taken in the module template repository: MetaMask/metamask-module-template#108 `auto-changelog` has also been updated; the version used previously was not compatible with Yarn v3.
Gudahtt
added a commit
to MetaMask/browser-passworder
that referenced
this pull request
Oct 26, 2022
Yarn has been updated following the steps taken in the module template repository: MetaMask/metamask-module-template#108 `auto-changelog` has also been updated; the version used previously was not compatible with Yarn v3.
Gudahtt
added a commit
to MetaMask/browser-passworder
that referenced
this pull request
Oct 31, 2022
Yarn has been updated following the steps taken in the module template repository: MetaMask/metamask-module-template#108 `auto-changelog` has also been updated; the version used previously was not compatible with Yarn v3.
Gudahtt
added a commit
to MetaMask/browser-passworder
that referenced
this pull request
Nov 3, 2022
Yarn has been updated following the steps taken in the module template repository: MetaMask/metamask-module-template#108 `auto-changelog` has also been updated; the version used previously was not compatible with Yarn v3.
Gudahtt
added a commit
to MetaMask/browser-passworder
that referenced
this pull request
Nov 3, 2022
Yarn has been updated following the steps taken in the module template repository: MetaMask/metamask-module-template#108 `auto-changelog` has also been updated; the version used previously was not compatible with Yarn v3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The package manager used has been upgraded from Yarn v1 to Yarn v3. All
of the steps in the migration guide have been followed, so
effectively everything should work the same way it did before. (Note
that we are not using Plug'n'Play because it seems to prevent TypeScript
from finding type definitions via
@types/*packages.)The
setupscript has been replaced with a Yarn v3 plugin that willautomatically run
allow-scriptsafter install. This means that we cannow use
yarn installagain as normal. This change was made to addressa problem that happened when running
yarn setupfor the first time.Yarn 3 doesn't automatically install itself until you run the
installcommand directly, so running the
setupscript beforeinstallwouldhave thrown an error. This is non-obvious, so we chose to remove
setupaltogether.
See original source in
controllers.