Skip to content

feat: allow npm:name@version dependency redirections in manifest #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
legobeat merged 2 commits into from
Oct 28, 2024
Merged

feat: allow npm:name@version dependency redirections in manifest #158

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac287c4
feat: allow "npm:name@version" dependency redirections in manifest
legobeat Oct 26, 2024
4f5d575
chore: test coverage
legobeat Oct 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
chore: test coverage
  • Loading branch information
@legobeat
legobeat committed Oct 26, 2024
commit 4f5d575acab26ae2538fc563e6fc81a3b98fed1d
8 changes: 5 additions & 3 deletions src/package-manifest.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ describe('package-manifest', () => {
b: '^2.0.0',
c: '~4.3.0',
d: 'workspace:^',
e: 'npm:a@^2.0.0',
e: 'npm:@a/abc@^2.0.0',
},
};
const validated = {
Expand All @@ -80,7 +80,7 @@ describe('package-manifest', () => {
b: '^2.0.0',
c: '~4.3.0',
d: 'workspace:^',
e: 'npm:a@^2.0.0',
e: 'npm:@a/abc@^2.0.0',
},
peerDependencies: {},
};
Expand Down Expand Up @@ -317,7 +317,9 @@ describe('package-manifest', () => {
name: 'foo',
version: '1.0.0',
peerDependencies: {
a: 12345,
a: 'npm:@foo',
b: 'npm:foo@',
c: '12345',
},
}),
);
Expand Down
5 changes: 3 additions & 2 deletions src/package-manifest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,8 @@ function isValidPackageManifestDependencyValue(
try {
const redirectedDependencyMatch = redirectedDependencyRegexp.exec(version);

if (!redirectedDependencyMatch || redirectedDependencyMatch.length < 3) {
/* istanbul ignore if */
if (!redirectedDependencyMatch) {
return false;
}

Expand All @@ -183,7 +184,7 @@ function isValidPackageManifestDependencyValue(
validateNPMPackageName(redirectedName)?.validForOldPackages &&
isValidPackageManifestVersionField(redirectedVersion)
);
} catch (e) {
} catch (e) /* istanbul ignore next */ {
return false;
}
}
Expand Down
Loading