Skip to content

Conversation

@Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Aug 7, 2025

Reverts #381 temporarily because it includes breaking changes, and we'd like to release the non-breaking changes on main without a major version bump. This will be restored after release.

@Gudahtt Gudahtt requested review from a team as code owners August 7, 2025 13:22
Copy link
Contributor

@cryptodev-2s cryptodev-2s left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt force-pushed the revert-381-rekm/actually-consistent-type-imports branch from f8b6c9b to f0c6b3c Compare August 7, 2025 13:28
@Gudahtt Gudahtt requested a review from a team as a code owner August 7, 2025 13:28
@Gudahtt Gudahtt merged commit cd9425a into main Aug 7, 2025
26 checks passed
@Gudahtt Gudahtt deleted the revert-381-rekm/actually-consistent-type-imports branch August 7, 2025 13:32
@Gudahtt Gudahtt restored the revert-381-rekm/actually-consistent-type-imports branch November 10, 2025 14:12
Gudahtt added a commit that referenced this pull request Nov 10, 2025
Gudahtt added a commit that referenced this pull request Nov 10, 2025
Gudahtt added a commit that referenced this pull request Nov 10, 2025
#418)

Reverts #407, which itself was a revert of
#381 because it had
breaking changes, and we wanted to release some non-breaking things
first.

This PR restores the breaking changes in #381.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> Replace @typescript-eslint/consistent-type-imports with
import-x/consistent-type-specifier-style (prefer-top-level) and enable
TypeScript verbatimModuleSyntax in tsconfigs.
> 
> - **TypeScript ESLint config (`packages/typescript/src/index.mjs`,
`rules-snapshot.json`)**:
> - Add `import-x/consistent-type-specifier-style: ["error",
"prefer-top-level"]` and keep `import-x/no-unresolved: "off"`.
>   - Remove `@typescript-eslint/consistent-type-imports`.
> - **TypeScript config (`tsconfig.json`,
`packages/typescript/tsconfig.json`)**:
>   - Enable `compilerOptions.verbatimModuleSyntax: true`.
> 
> <sup>Written by [Cursor
Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit
245508b. This will update automatically
on new commits. Configure
[here](https://cursor.com/dashboard?tab=bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants