-
Notifications
You must be signed in to change notification settings - Fork 19
Allow remaining TypeScript 5.x versions #422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest version of TypeScript is 5.9, but no project can currently use this without producing peer dependency warnings. To prevent this and unlock new versions of TypeScript in the future, widen the peer dependencies: - Allow TypeScript 5.9 and any future version up to 6 - Allow TypeScript ESLint versions betwen 8.24 and 9 To ensure this does not cause a problem in this repo, also update the development version of TypeScript and TypeScript ESLint to their latest versions.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning MetaMask internal reviewing guidelines:
|
| eslint: ^8.57.0 || ^9.0.0 | ||
| typescript: ">=4.8.4 <5.9.0" | ||
| checksum: 10/cd83f6c52218f7d31142b08a73b398370e4a7cf95c8afc03821050c625ec4b35e0c56f554d48bfa4a1b95564e60c0b4d5993cf2054b80f39533c1b0b84a0c7cd | ||
| typescript: ">=4.8.4 <6.0.0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I was going to say that we shouldn't widen beyond what the plugin requires, but the plugin has widened the supported range too! That's great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, technically the range wasn't widened to allow this until v8.39, which is still well ahead of our minimum. But I can address this in a separate PR, I wanted to bump the minimum for other reasons anyway.
Gudahtt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The latest version of TypeScript is 5.9, but no project can currently use this without producing peer dependency warnings. To prevent this and unlock new versions of TypeScript 5.x in the future, widen the peer dependency.
To ensure this does not cause a problem in this repo, also update the development version of TypeScript and TypeScript ESLint to their latest versions.
Note
Widen TypeScript peer dependency to <6 and upgrade dev deps to TypeScript 5.9.3 and typescript-eslint 8.47, with test tweaks and rules snapshot update.
peerDependencies.typescriptto>=4.8.4 <6inpackages/typescript/package.json.typescriptto^5.9.3andtypescript-eslintto^8.47.0in root andpackages/typescript.yarn.lock(e.g.,@typescript-eslint/*,eslint-utils,ignore,ts-api-utils).parserOptions.projectfrom ESLint config tests inpackages/jest/src/index.test.mjsandpackages/typescript/src/index.test.mjs."no-with": "off"inpackages/typescript/rules-snapshot.json.Written by Cursor Bugbot for commit 5aa2880. This will update automatically on new commits. Configure here.