Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/typescript/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- This version has a matching supported `typescript` range, and includes some bug fixes for problems we ran into.
- Disable `@typescript-eslint/no-unnecessary-type-arguments` ([#426](https://github.com/MetaMask/eslint-config/pull/426))
- We decided that "unnecessary" type arguments make types easier to read sometimes, so we should allow them.
- Disable `promise/valid-params` because it's redundant in type-checked projects ([#425](https://github.com/MetaMask/eslint-config/pull/425))

## [14.1.0]

Expand Down
1 change: 1 addition & 0 deletions packages/typescript/rules-snapshot.json
Original file line number Diff line number Diff line change
Expand Up @@ -250,5 +250,6 @@
"prefer-promise-reject-errors": "off",
"prefer-rest-params": "error",
"prefer-spread": "error",
"promise/valid-params": "off",
"require-await": "off"
}
5 changes: 5 additions & 0 deletions packages/typescript/src/index.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,11 @@ const config = createConfig({
message: 'Use a hash name instead.',
},
],

/* promise plugin rules */

// TypeScript already validates Promise params, no need to validate them twice
'promise/valid-params': 'off',
},
});

Expand Down
Loading