Skip to content

Conversation

@AyushBherwani1998
Copy link
Member

@AyushBherwani1998 AyushBherwani1998 commented Dec 5, 2025

Description

  • Update Dynamic example to use v0.2.0 of smart-accounts-kit
  • Update NEXT js version

Note

Updates the Dynamic smart accounts example to use @metamask/smart-accounts-kit v0.2.0 and Next 15.4.8, tweaks UI copy/links, marks components as client, and hardens form value handling.

  • Examples: Dynamic signer
    • Dependencies: Bump @metamask/smart-accounts-kit to ^0.2.0, next to 15.4.8, eslint-config-next to 15.4.8; update lockfile (notably sharp and platform binaries).
    • UI/Copy: Update metadata title/description in src/app/layout.tsx; change footer docs link to smart-accounts-kit.
    • Client Components: Add "use client" to Steps, TransactionForm, and SendUserOperationButton; remove unused import in Steps.
    • Form Validation: In TransactionForm, pass 0n when value is invalid to avoid parse errors.

Written by Cursor Bugbot for commit 53fec39. This will update automatically on new commits. Configure here.

@AyushBherwani1998 AyushBherwani1998 requested review from a team as code owners December 5, 2025 05:46
@socket-security
Copy link

socket-security bot commented Dec 5, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Updatedeslint-config-next@​15.3.4 ⏵ 15.4.899 +110065 +198 +1100
Updated@​metamask/​smart-accounts-kit@​0.1.0 ⏵ 0.2.08010095 +191 +4100
Updatednext@​15.3.4 ⏵ 15.4.88383 +5891 +198 +4870

View full report

@socket-security
Copy link

socket-security bot commented Dec 5, 2025

Caution

MetaMask internal reviewing guidelines:

  • Do not ignore-all
  • Each alert has instructions on how to review if you don't know what it means. If lost, ask your Security Liaison or the supply-chain group
  • Copy-paste ignore lines for specific packages or a group of one kind with a note on what research you did to deem it safe.
    @SocketSecurity ignore npm/PACKAGE@VERSION
Action Severity Alert  (click "▶" to expand/collapse)
Block Medium
Network access: npm @metamask/smart-accounts-kit in module globalThis["fetch"]

Module: globalThis["fetch"]

Location: Package overview

From: examples/smart-accounts/signers/dynamic/package.jsonnpm/@metamask/[email protected]

ℹ Read more on: This package | This alert | What is network access?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Packages should remove all network access that is functionally unnecessary. Consumers should audit network access to ensure legitimate use.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/@metamask/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Medium
Install-time scripts: npm sharp during install

Install script: install

Source: node install/check.js || npm run build

From: ?npm/[email protected]npm/[email protected]

ℹ Read more on: This package | This alert | What is an install script?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Low
Potential code anomaly (AI signal): npm next is 100.0% likely to have a medium risk anomaly

Notes: The code appears to implement expected behavior for downloading and running mkcert to produce local development TLS certificates. It does not contain obvious malware (no credential exfiltration, no reverse shell code, no obfuscated payloads). However there are significant supply-chain and injection risks: it downloads an executable at runtime from a remote URL and executes it, and it interpolates an unescaped host value into a shell command passed to child_process.execSync, creating a command-injection vector if host is attacker-controlled. Recommendation: validate or sanitize 'host' input, avoid executing downloaded binaries without integrity checks (e.g., verify checksum/signature), and prefer execFile/spawn with argument arrays instead of string commands to avoid shell interpretation. Use stricter error handling to surface failures instead of silently falling back.

Confidence: 1.00

Severity: 0.60

From: examples/smart-accounts/signers/dynamic/package.jsonnpm/[email protected]

ℹ Read more on: This package | This alert | What is an AI-detected potential code anomaly?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

Warn Low
Potential code anomaly (AI signal): npm next is 100.0% likely to have a medium risk anomaly

Notes: The code is a legitimate worker orchestration utility for parallel build tasks, consistent with Next.js build tooling. The primary security concerns arise from reliance on private internals of an external library (fragility and potential breakage with library updates) and exposure of environment/config via forked processes (IS_NEXT_WORKER, NODE_OPTIONS). There is no evidence of malicious activity such as data theft or remote control in this fragment. Overall, it presents moderate security risk due to integration fragility and potential information leakage through logs, but not due to explicit malware.

Confidence: 1.00

Severity: 0.60

From: examples/smart-accounts/signers/dynamic/package.jsonnpm/[email protected]

ℹ Read more on: This package | This alert | What is an AI-detected potential code anomaly?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at [email protected].

Suggestion: An AI system found a low-risk anomaly in this package. It may still be fine to use, but you should check that it is safe before proceeding.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore npm/[email protected]. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

mj-kiwi
mj-kiwi previously approved these changes Dec 10, 2025
jeffsmale90
jeffsmale90 previously approved these changes Dec 12, 2025
Copy link
Contributor

@jeffsmale90 jeffsmale90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants