-
-
Notifications
You must be signed in to change notification settings - Fork 4
INFRA-2867-Added chore prefix to PR, await for create release, remove commits.csv from changelog pr #111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| # Commit and Push Changelog Changes | ||
| # Commit and Push Changelog Changes (exclude commits.csv) | ||
| echo "Adding and committing changes.." | ||
| git add ./commits.csv |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reached out to @jvbriones on Slack to confirm he's fine with this removal.
| ); | ||
|
|
||
| createReleaseSheet( | ||
| await createReleaseSheet( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is dead code that will be removed by @jvbriones (the entire file).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will leave it here for now then until it's removed if there's no objections.
… csv from changelog pr
…ve csv from changelog pr
642dfcb to
4000ff0
Compare
…ve csv from changelog pr, add workflow artifact
Ticket: https://consensyssoftware.atlassian.net/browse/INFRA-2867
Added release prefix to PR, await for create release, remove commits.csv from changelog pr, add commits.csv to workflow artifacts
Tested here: https://github.com/consensys-test/metamask-extension-test-workflow2/actions/runs/17270524861/job/49013733053, https://github.com/consensys-test/metamask-extension-test-workflow2/actions/runs/17272422001
consensys-test/metamask-extension-test-workflow2#28 (No commits.csv)
consensys-test/metamask-extension-test-workflow2#32 (Added release prefix)
https://github.com/consensys-test/metamask-extension-test-workflow2/actions/runs/17272422001 (commits.csv workflow artifact)