Skip to content

Conversation

@XxdpavelxX
Copy link
Contributor

@XxdpavelxX XxdpavelxX commented Aug 27, 2025

Ticket: https://consensyssoftware.atlassian.net/browse/INFRA-2867
Added release prefix to PR, await for create release, remove commits.csv from changelog pr, add commits.csv to workflow artifacts

The Github Action doesn’t inform us when [createReleaseSheet](https://github.com/MetaMask/github-tools/blob/dde6d530bebae07d1e50180894ab2cac64170a2c/.github/scripts/update-release-sheet.mjs#L313) succeeds or fails, we should add an ‘await’ in front of it.

The changelog PR shall not include ‘commits.csv’ as we have here: [MetaMask/metamask-extension@](https://github.com/MetaMask/metamask-extension/commit/e6be418e07eb04d47ce7dd07432a2136382f1180#r2254840331)e6be418[#r2254840331](https://github.com/MetaMask/metamask-extension/commit/e6be418e07eb04d47ce7dd07432a2136382f1180#r2254840331)

The title of the version bump PR created by the Github Action doesn’t respect conventional commits format, which makes the CI fail. It should be prefixed with release: .

Tested here: https://github.com/consensys-test/metamask-extension-test-workflow2/actions/runs/17270524861/job/49013733053, https://github.com/consensys-test/metamask-extension-test-workflow2/actions/runs/17272422001
consensys-test/metamask-extension-test-workflow2#28 (No commits.csv)
consensys-test/metamask-extension-test-workflow2#32 (Added release prefix)
https://github.com/consensys-test/metamask-extension-test-workflow2/actions/runs/17272422001 (commits.csv workflow artifact)

@XxdpavelxX XxdpavelxX changed the title INFRA-2867-Added chore prefix to PR, await for create release, remove csv from changelog pr INFRA-2867-Added chore prefix to PR, await for create release, remove commits.csv from changelog pr Aug 27, 2025
# Commit and Push Changelog Changes
# Commit and Push Changelog Changes (exclude commits.csv)
echo "Adding and committing changes.."
git add ./commits.csv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reached out to @jvbriones on Slack to confirm he's fine with this removal.

);

createReleaseSheet(
await createReleaseSheet(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is dead code that will be removed by @jvbriones (the entire file).

Copy link
Contributor Author

@XxdpavelxX XxdpavelxX Aug 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I will leave it here for now then until it's removed if there's no objections.

@XxdpavelxX XxdpavelxX force-pushed the INFRA-2867-CreateReleaseUpdates branch from 642dfcb to 4000ff0 Compare August 27, 2025 15:32
…ve csv from changelog pr, add workflow artifact
@XxdpavelxX XxdpavelxX merged commit 03eade1 into main Aug 27, 2025
19 checks passed
@XxdpavelxX XxdpavelxX deleted the INFRA-2867-CreateReleaseUpdates branch August 27, 2025 16:32
@XxdpavelxX XxdpavelxX restored the INFRA-2867-CreateReleaseUpdates branch August 27, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants