generated from MetaMask/metamask-module-template
-
-
Notifications
You must be signed in to change notification settings - Fork 4
INFRA-2911-Skip generating commits.csv for hotfixes #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
5ecff75
INFRA-2911-Skip generating commits.dvs for hotfixes
XxdpavelxX 3ae9840
INFRA-2911-Skip generating commits.dvs for hotfixes
XxdpavelxX a7527bc
INFRA-2911-Skip generating commits.cvs for hotfixes
XxdpavelxX 24214ba
INFRA-2911-Skip generating commits.cvs for hotfixes
XxdpavelxX 66e16bf
INFRA-2911-Skip generating commits.cvs for hotfixes
XxdpavelxX 8d9c1ed
INFRA-2911-Skip generating commits.cvs for hotfixes
XxdpavelxX dabffc0
INFRA-2911-Skip generating commits.cvs for hotfixes
XxdpavelxX 3f1587e
INFRA-2911-Skip generating commits.cvs for hotfixes
XxdpavelxX bbbb67e
INFRA-2911-Skip generating commits.cvs for hotfixes
XxdpavelxX 5e15345
INFRA-2911-Skip generating commits.cvs for hotfixes
XxdpavelxX a9d33d5
INFRA-2911-Skip generating commits.cvs for hotfixes
XxdpavelxX 90a5adf
INFRA-2911-Skip generating commits.cvs for hotfixes
XxdpavelxX bb2b66d
INFRA-2911-Skip generating commits.cvs for hotfixes
XxdpavelxX 863e289
INFRA-2911-Skip generating commits.cvs for hotfixes
XxdpavelxX File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
INFRA-2911-Skip generating commits.cvs for hotfixes
- Loading branch information
commit dabffc04db49cfc9daff62a566641e22a7728368
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,24 +22,15 @@ set -e | |
| set -u | ||
| set -o pipefail | ||
|
|
||
| # Log all positional arguments for debugging | ||
| echo "Script called with arguments:" | ||
| echo "1 (PLATFORM): $1" | ||
| echo "2 (PREVIOUS_VERSION_REF): $2" | ||
| echo "3 (NEW_VERSION): $3" | ||
| echo "4 (NEW_VERSION_NUMBER): $4" | ||
| echo "5 (GIT_USER_NAME): $5" | ||
| echo "6 (GIT_USER_EMAIL): $6" | ||
|
|
||
| # Input validation | ||
| PLATFORM="${1}" | ||
| PREVIOUS_VERSION_REF="${2//[[:space:]]/}" # Trim whitespace | ||
| NEW_VERSION="${3}" | ||
| NEW_VERSION="${3//[[:space:]]/}" # Trim whitespace | ||
| NEW_VERSION_NUMBER="${4:-}" | ||
| GIT_USER_NAME="${5:-metamaskbot}" | ||
| GIT_USER_EMAIL="${6:[email protected]}" | ||
|
|
||
| # Move logging here | ||
| # Log assigned variables for debugging (after defaults and trimming) | ||
| echo "Assigned variables:" | ||
| echo "PLATFORM: $PLATFORM" | ||
| echo "PREVIOUS_VERSION_REF: $PREVIOUS_VERSION_REF" | ||
|
|
@@ -48,9 +39,6 @@ echo "NEW_VERSION_NUMBER: $NEW_VERSION_NUMBER" | |
| echo "GIT_USER_NAME: $GIT_USER_NAME" | ||
| echo "GIT_USER_EMAIL: $GIT_USER_EMAIL" | ||
|
|
||
| # Add trimming for NEW_VERSION | ||
| NEW_VERSION="${NEW_VERSION//[[:space:]]/}" | ||
|
|
||
| # Validate required parameters | ||
| if [[ -z $PLATFORM ]]; then | ||
| echo "Error: No platform specified." | ||
|
|
@@ -68,8 +56,8 @@ if [[ -z $NEW_VERSION_NUMBER && $PLATFORM == "mobile" ]]; then | |
| fi | ||
|
|
||
| if [[ -z $PREVIOUS_VERSION_REF ]]; then | ||
| echo "Error: No previous version reference specified." | ||
| exit 1 | ||
| echo "Error: No previous version reference specified." | ||
| exit 1 | ||
| fi | ||
|
|
||
|
|
||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.