Skip to content

Conversation

@jvbriones
Copy link
Contributor

@jvbriones jvbriones commented Aug 5, 2025

Add a new reusable workflow to add a comment in the feat and perf PRs asking for a validation in main once they get merged. This reusable workflow will be used for MM extension and mobile repos.

@metamaskbot metamaskbot added the team-qa team-qa label Aug 5, 2025
cursor[bot]

This comment was marked as outdated.

@jvbriones jvbriones changed the title Chore post validation feat: chore post validation Aug 5, 2025
cursor[bot]

This comment was marked as outdated.


const body = `Hi @${author},

on the day following \`feat\` or \`perf\` PR merge, PM and author to test changes on main (feature + exploratory around the edges) using the latest [nightly build](https://consensys.slack.com/archives/C093JQSEPJL) with [casual user persona](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085221547/Mobile+User+Persona+Definition) and also a [power user persona](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085221547/Mobile+User+Persona+Definition) where performance might be a challenge. Please record the testing in a video, check the relevant post-merge checklist box below, and post the video in a comment at the bottom of this PR.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: GitHub Workflow Comment Links Incorrect

The GitHub workflow's generated comment contains a copy-paste error: both "casual user persona" and "power user persona" links point to the same documentation URL, despite representing distinct personas that should link to separate pages.

Fix in Cursor Fix in Web

@jvbriones jvbriones changed the title feat: chore post validation feat: post validation bot to add a checklist in feat and perf PRs Aug 6, 2025
@jvbriones jvbriones merged commit 59141c3 into main Aug 6, 2025
19 checks passed
@jvbriones jvbriones deleted the chore-post-validation branch August 6, 2025 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-qa team-qa

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants