This repository was archived by the owner on Nov 9, 2023. It is now read-only.
Use async/await and try/catch in place of Promise methods#74
Merged
Conversation
Gudahtt
approved these changes
Nov 20, 2020
Member
Gudahtt
left a comment
Gudahtt
left a comment
There was a problem hiding this comment.
LGTM!
It's not entirely clear why the callback was moved into _handleBatch, but either way it all looks correct to me
Ashuk777
approved these changes
Feb 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces all uses of
Promise.thenand.catchwithasync/awaitandtry/catch.Tested with latest MetaMask extension and
rpc-cap. Both work once the import issues are resolved.