This repository was archived by the owner on Nov 9, 2023. It is now read-only.
Conversation
brad-decker
approved these changes
Nov 20, 2020
zaeguerra
approved these changes
Jul 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using the
JsonRpcResponsetype in middleware became really painful when implementing middleware. When a response object is in a middleware, it's not a finished response; it's pending. If you useJsonRpcResponse, you have to re-cast the response object in order to set eithererrororresult. That sucks.To fix this sorry state of affairs, this PR replaces the
InternalJsonRpcResponseinterface with an exported, genericizedPendingJsonRpcResponseinterface. This could be abused in terms of type safety by setting bothresultanderroron a response, butresultwill be deleted iferroris present.