-
-
Notifications
You must be signed in to change notification settings - Fork 7
chore: upgrade react native, expo and storybook #685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub. |
|
Caution MetaMask internal reviewing guidelines:
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
793a046 to
493ddde
Compare
📖 Storybook Preview |
| // Only use FontLoader in native environment | ||
| if (Platform.OS !== 'web') { | ||
| return ( | ||
| <ThemeProvider theme={Theme.Default} colorSet={ColorSet.Brand}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove color set and use useColorScheme hook from react native
| import * as Font from 'expo-font'; | ||
|
|
||
| const FontLoader = ({ children }) => { | ||
| interface FontLoaderProps { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use type here
📖 Storybook Preview |
fcdf533 to
58f2edc
Compare
📖 Storybook Preview |
📖 Storybook Preview |
58f2edc to
12bd36c
Compare
📖 Storybook Preview |
12bd36c to
dd2c993
Compare
📖 Storybook Preview |
Description
This PR upgrades React Native, Expo, and Storybook dependencies for the storybook-react-native app to align with MetaMask Mobile's dependency versions and upgrade to Storybook v10.
Key Changes:
Dependency Upgrades:
react-native-safe-area-contextfrom 4.12.0 to 5.6.0react-native-gesture-handlerfrom 2.20.2 to 2.28.0@gorhom/bottom-sheetfrom 5.1.1 to 5.2.6react-native-svgfrom 15.10.1 to 15.8.0 (Expo SDK 52 compatibility)Storybook UI Workaround:
@storybook/react-native-ui-liteto fix bottom sheet menu issueMetro Configuration:
withStorybookimport to use named export (Storybook v10 API change)Babel Configuration:
react-native-reanimated/pluginas the last plugin (required for Reanimated v3)Known Issues:
SVG Rendering Errors: When using Expo Go, SVG icons throw native module initialization errors:
This is a known limitation when using custom SVG transformers with Expo Go. The error occurs because the
react-native-svgnative module doesn't properly initialize with the custom transformer configuration.Workaround Options:
npx expo prebuild)Related issues
Fixes: N/A
Related:
Manual testing steps
yarn installin the repository rootapps/storybook-react-nativeyarn storybook:iosoryarn storybook:androidScreenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist