fix: Updated font file across apps and packages#801
Merged
georgewrmarshall merged 2 commits intomainfrom Jul 31, 2025
Merged
Conversation
Contributor
📖 Storybook Preview |
Contributor
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
georgewrmarshall
approved these changes
Jul 31, 2025
Contributor
There was a problem hiding this comment.
Font's look good in storybook but still seem to be getting the same error in the mobile codebase with the publish preview packages. I'll merge so we can do a release and see if the actual packages fixes it... This will be considered a breaking change as we will need to update the fonts in portfolio and extension to be the same as our design system components
fotns.mov
Contributor
📖 Storybook Preview |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the font files name to align with the font files in @metamask-mobile
Related issues
Fixes:
Manual testing steps
yarn setupthenyarn storybookoryarn storybook:iosScreenshots/Recordings
Before
After
React
https://github.com/user-attachments/assets/8b776e63-f272-4e20-8d96-db2afc795869
React Native
https://github.com/user-attachments/assets/725f0171-916d-4a29-b736-cd335b59cf3f
Pre-merge author checklist
Pre-merge reviewer checklist