Skip to content

fix: Updated font file across apps and packages#801

Merged
georgewrmarshall merged 2 commits intomainfrom
fix/font-files
Jul 31, 2025
Merged

fix: Updated font file across apps and packages#801
georgewrmarshall merged 2 commits intomainfrom
fix/font-files

Conversation

@brianacnguyen
Copy link
Contributor

Description

This PR updates the font files name to align with the font files in @metamask-mobile

Related issues

Fixes:

Manual testing steps

  1. Run yarn setup then yarn storybook or yarn storybook:ios
  2. Check the fonts and texts

Screenshots/Recordings

Before

After

React
https://github.com/user-attachments/assets/8b776e63-f272-4e20-8d96-db2afc795869

React Native
https://github.com/user-attachments/assets/725f0171-916d-4a29-b736-cd335b59cf3f

Pre-merge author checklist

  • I've followed MetaMask Contributor Docs
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@brianacnguyen brianacnguyen self-assigned this Jul 31, 2025
@brianacnguyen brianacnguyen requested a review from a team as a code owner July 31, 2025 21:31
@github-actions
Copy link
Contributor

📖 Storybook Preview

@georgewrmarshall
Copy link
Contributor

@metamaskbot publish-preview

@github-actions
Copy link
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/design-system-react": "0.2.0-preview.ec6504c",
  "@metamask-previews/design-system-react-native": "0.2.0-preview.ec6504c",
  "@metamask-previews/design-system-tailwind-preset": "0.6.0-preview.ec6504c",
  "@metamask-previews/design-system-twrnc-preset": "0.2.0-preview.ec6504c",
  "@metamask-previews/design-tokens": "8.1.0-preview.ec6504c"
}

Copy link
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Font's look good in storybook but still seem to be getting the same error in the mobile codebase with the publish preview packages. I'll merge so we can do a release and see if the actual packages fixes it... This will be considered a breaking change as we will need to update the fonts in portfolio and extension to be the same as our design system components

Screenshot 2025-07-31 at 3 44 20 PM
fotns.mov

@github-actions
Copy link
Contributor

📖 Storybook Preview

@georgewrmarshall georgewrmarshall merged commit c5ef9a9 into main Jul 31, 2025
38 checks passed
@georgewrmarshall georgewrmarshall deleted the fix/font-files branch July 31, 2025 23:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants