Skip to content

fix: ensure peer dependencies reflect latest breaking changes for pre-1.0 packages #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgewrmarshall merged 2 commits into from
Sep 19, 2025
Merged

fix: ensure peer dependencies reflect latest breaking changes for pre-1.0 packages #836

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0defaf6
chore: implementing improved peer dependency checks for pre-1.0 packages
georgewrmarshall Sep 18, 2025
2107ec9
Merge branch 'main' into fix/peer-deps-yarn-config
georgewrmarshall Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore: implementing improved peer dependency checks for pre-1.0 packages
  • Loading branch information
@georgewrmarshall
georgewrmarshall committed Sep 18, 2025
commit 0defaf60dbe8528fdc447967567eaaea8d9bdee5
15 changes: 14 additions & 1 deletion yarn.config.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -613,10 +613,23 @@ function expectUpToDateWorkspacePeerDependencies(Yarn, workspace) {
dependency.range,
)
) {
// Ensure peer dependency includes latest breaking changes.
//
// Technically pre-1.0 versions can make breaking changes in patch releases, but
// conventionally we always bump the most significant digit for breaking changes.
let peerDependencyRange;
if (dependencyWorkspaceVersion.major > 0) {
peerDependencyRange = `^${dependencyWorkspaceVersion.major}.0.0`;
} else if (dependencyWorkspaceVersion.minor > 0) {
peerDependencyRange = `^0.${dependencyWorkspaceVersion.minor}.0`;
} else {
peerDependencyRange = `^0.0.${dependencyWorkspaceVersion.patch}`;
}

expectWorkspaceField(
workspace,
`peerDependencies["${dependency.ident}"]`,
`^${dependencyWorkspaceVersion.major}.0.0`,
peerDependencyRange,
);
}
}
Expand Down
Loading