Skip to content

feat: add ButtonHero component to design system react #843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgewrmarshall merged 4 commits into from
Oct 22, 2025
Merged

feat: add ButtonHero component to design system react #843

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
455ef16
feat: adding button hero component
georgewrmarshall Oct 21, 2025
0374d40
Update packages/design-system-react/src/components/ButtonHero/README.mdx
georgewrmarshall Oct 22, 2025
0784cbe
chore: operator fix
georgewrmarshall Oct 22, 2025
1a07daa
Merge branch 'main' into feat/button-hero-dsr
georgewrmarshall Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: operator fix
  • Loading branch information
@georgewrmarshall
georgewrmarshall committed Oct 22, 2025
commit 0784cbebc2dcdd2b1be8ba2b897877eea936f2f9
2 changes: 1 addition & 1 deletion packages/design-system-react/src/components/ButtonHero/ButtonHero.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import type { ButtonHeroProps } from './ButtonHero.types';

export const ButtonHero = forwardRef<HTMLButtonElement, ButtonHeroProps>(
({ className, isDisabled, isLoading, ...props }, ref) => {
const isInteractive = !(isDisabled ?? isLoading);
const isInteractive = !(isDisabled || isLoading);

const mergedClassName = twMerge(
// Base hero styles - locked to light theme primary colors
Expand Down
Loading