-
-
Notifications
You must be signed in to change notification settings - Fork 7
chore: update font weight from bold to semi-bold for Geist font alignment #847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
3db7f64
a416b52
01a59b9
2dc1e8f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,15 +34,15 @@ | |
| @font-face { | ||
| font-family: 'Geist'; | ||
| font-style: normal; | ||
| font-weight: 700; | ||
| src: url('fonts/Geist/Geist Bold.woff2') format('woff2'); | ||
| font-weight: 600; | ||
| src: url('fonts/Geist/Geist SemiBold.woff2') format('woff2'); | ||
| } | ||
|
|
||
| @font-face { | ||
| font-family: 'Geist'; | ||
| font-style: italic; | ||
| font-weight: 700; | ||
| src: url('fonts/Geist/Geist Bold Italic.woff2') format('woff2'); | ||
| font-weight: 600; | ||
| src: url('fonts/Geist/Geist SemiBold Italic.woff2') format('woff2'); | ||
|
Comment on lines
-37
to
+45
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Updating @font-face to point to SemiBold and adjusting weight from |
||
| } | ||
|
|
||
| /* MM Sans */ | ||
|
|
@@ -63,7 +63,7 @@ | |
| @font-face { | ||
| font-family: 'MMSans'; | ||
| font-style: normal; | ||
| font-weight: 700; | ||
| font-weight: 600; | ||
| src: url('fonts/MMSans/MM Sans Bold.woff2') format('woff2'); | ||
| } | ||
|
|
||
|
|
@@ -85,6 +85,6 @@ | |
| @font-face { | ||
| font-family: 'MMPoly'; | ||
| font-style: normal; | ||
| font-weight: 700; | ||
| font-weight: 600; | ||
| src: url('fonts/MMPoly/MM Poly Regular.woff2') format('woff2'); | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -76,7 +76,7 @@ Available `FontWeight` options: | |
|
|
||
| - `FontWeight.Regular` (Weight `400`) | ||
| - `FontWeight.Medium` (Weight `500`) | ||
| - `FontWeight.Bold` (Weight `700`) | ||
| - `FontWeight.Bold` (Weight `600`) | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
|
|
||
| ### `fontStyle` | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -404,7 +404,7 @@ | |
| "type": "fontWeights" | ||
| }, | ||
| "bold": { | ||
| "value": "700", | ||
| "value": "600", | ||
| "type": "fontWeights" | ||
| } | ||
| }, | ||
|
|
||



There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating FontLoader in for storybook-react native to point to semi bold