Skip to content

chore(deps-dev): bump @metamask/eslint-config from 14.1.0 to 15.0.0 #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgewrmarshall merged 2 commits into from
Dec 4, 2025
Merged

chore(deps-dev): bump @metamask/eslint-config from 14.1.0 to 15.0.0 #854

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
115f472
chore: ignoring jsdoc rule similarly to core https://github.com/MetaM…
georgewrmarshall Dec 4, 2025
61c59be
Merge branch 'main' into dependabot/npm_and_yarn/metamask/eslint-conf…
georgewrmarshall Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,11 @@ const config = createConfig([
rules: {
Copy link
Contributor

@georgewrmarshall georgewrmarshall Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring jsdoc require rules as we have over 900+ violations an the auto fix doesn't really work. Core does the same thing https://github.com/MetaMask/core/pull/7305/files?file-filters%5B%5D=.mjs#diff-9601a8f6c734c2001be34a2361f76946d19a39a709b5e8c624a2a5a0aade05f2

What yarn lint:fix looks like without disabling these rules and lint still fails

Image

// TODO: Re-enable this
'n/no-sync': 'off',
// TODO: Re-enable these rules. Enabling them with error suppression
// breaks `--fix`, because the autofixer for these rules do not work very
// well.
'jsdoc/require-jsdoc': 'off',
'jsdoc/check-tag-names': 'off',
Comment on lines +80 to +84
Copy link
Contributor

@georgewrmarshall georgewrmarshall Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignores all base files

},
},
{
Expand Down Expand Up @@ -134,6 +139,12 @@ const config = createConfig([
'no-restricted-globals': 'off',
'@typescript-eslint/explicit-function-return-type': 'off',

// TODO: Re-enable these rules. Enabling them with error suppression
// breaks `--fix`, because the autofixer for these rules do not work very
// well.
'jsdoc/require-jsdoc': 'off',
'jsdoc/check-tag-names': 'off',
Comment on lines +142 to +146
Copy link
Contributor

@georgewrmarshall georgewrmarshall Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignores for typescript files


// Overrides eslint base config which isn't following outer most pattern. Can be removed once this issue is resolved and eslint config updated
// issue: https://github.com/MetaMask/eslint-config/issues/403
'import-x/order': [
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@
"@figma/code-connect": "^1.0.0",
"@lavamoat/allow-scripts": "^3.2.1",
"@metamask/create-release-branch": "^4.1.3",
"@metamask/eslint-config": "^14.1.0",
"@metamask/eslint-config": "^15.0.0",
"@metamask/eslint-config-jest": "^15.0.0",
"@metamask/eslint-config-nodejs": "^15.0.0",
"@metamask/eslint-config-typescript": "^15.0.0",
Expand Down
10 changes: 5 additions & 5 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3363,9 +3363,9 @@ __metadata:
languageName: node
linkType: hard

"@metamask/eslint-config@npm:^14.1.0":
version: 14.1.0
resolution: "@metamask/eslint-config@npm:14.1.0"
"@metamask/eslint-config@npm:^15.0.0":
version: 15.0.0
resolution: "@metamask/eslint-config@npm:15.0.0"
dependencies:
"@eslint/js": "npm:^9.11.0"
globals: "npm:^15.9.0"
Expand All @@ -3377,7 +3377,7 @@ __metadata:
eslint-plugin-prettier: ^5.2.1
eslint-plugin-promise: ^7.1.0
prettier: ^3.3.3
checksum: 10/c6313391ea09130ae7254356069c8c28621d8dac668278291cba4436e95d4d5b8a43e11d7ce98ade96b2e4c7706171eba9c966ce7ba439fe888576bb32930b06
checksum: 10/93eb41bd61f3f4a0cf930a3d83e8893455f4f03339e91b21ef5a2835d24532db7c2916138a3e1b64777b5fb95cbe4ac90107697ac6f962c11ea7a99955cc75e4
languageName: node
linkType: hard

Expand All @@ -3401,7 +3401,7 @@ __metadata:
"@figma/code-connect": "npm:^1.0.0"
"@lavamoat/allow-scripts": "npm:^3.2.1"
"@metamask/create-release-branch": "npm:^4.1.3"
"@metamask/eslint-config": "npm:^14.1.0"
"@metamask/eslint-config": "npm:^15.0.0"
"@metamask/eslint-config-jest": "npm:^15.0.0"
"@metamask/eslint-config-nodejs": "npm:^15.0.0"
"@metamask/eslint-config-typescript": "npm:^15.0.0"
Expand Down
Loading