Skip to content

chore(deps-dev): bump @metamask/eslint-config-nodejs from 14.0.0 to 15.0.0 #857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgewrmarshall merged 2 commits into from
Dec 4, 2025
Merged

chore(deps-dev): bump @metamask/eslint-config-nodejs from 14.0.0 to 15.0.0 #857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc73d56
chore(deps-dev): bump @metamask/eslint-config-nodejs
dependabot[bot] Dec 4, 2025
d1c3d91
Merge branch 'main' into dependabot/npm_and_yarn/metamask/eslint-conf…
georgewrmarshall Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
"@metamask/create-release-branch": "^4.1.3",
"@metamask/eslint-config": "^14.1.0",
"@metamask/eslint-config-jest": "^15.0.0",
"@metamask/eslint-config-nodejs": "^14.0.0",
"@metamask/eslint-config-nodejs": "^15.0.0",
Copy link

@cursor cursor bot Dec 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Peer dependency mismatch for eslint-config packages

The @metamask/[email protected] package requires a peer dependency of @metamask/eslint-config@^15.0.0, but the project still has @metamask/eslint-config@^14.1.0 installed. This version mismatch will cause peer dependency warnings and may result in incompatible ESLint rule configurations or runtime errors since the nodejs config expects features from the v15 base config that aren't present in v14.

Additional Locations (1)

Fix in Cursor Fix in Web

Copy link

@cursor cursor bot Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Peer dependency mismatch with eslint-config version

The @metamask/[email protected] package requires @metamask/eslint-config@^15.0.0 as a peer dependency, but the project still specifies @metamask/eslint-config@^14.1.0. Similarly, @metamask/[email protected] also requires @metamask/eslint-config@^15.0.0. This version mismatch could cause ESLint configuration conflicts or runtime errors since the peer dependency requirement is not satisfied.

Additional Locations (1)

Fix in Cursor Fix in Web

Copy link

@cursor cursor bot Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: Peer dependency mismatch with base eslint-config package

The @metamask/eslint-config-nodejs package was bumped to version 15.0.0, which requires @metamask/eslint-config@^15.0.0 as a peer dependency. However, @metamask/eslint-config remains at ^14.1.0. This peer dependency mismatch (also affecting @metamask/[email protected]) may cause installation warnings and potential configuration incompatibilities. The base @metamask/eslint-config package needs to be updated to version 15.0.0 to satisfy these peer dependency requirements.

Fix in Cursor Fix in Web

"@metamask/eslint-config-typescript": "^14.1.0",
"@metamask/utils": "^11.8.1",
"@types/eslint-plugin-tailwindcss": "^3",
Expand Down
12 changes: 6 additions & 6 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3332,17 +3332,17 @@ __metadata:
languageName: node
linkType: hard

"@metamask/eslint-config-nodejs@npm:^14.0.0":
version: 14.0.0
resolution: "@metamask/eslint-config-nodejs@npm:14.0.0"
"@metamask/eslint-config-nodejs@npm:^15.0.0":
version: 15.0.0
resolution: "@metamask/eslint-config-nodejs@npm:15.0.0"
dependencies:
"@eslint/js": "npm:^9.11.0"
globals: "npm:^15.9.0"
peerDependencies:
"@metamask/eslint-config": ^14.0.0
"@metamask/eslint-config": ^15.0.0
eslint: ^9.11.0
eslint-plugin-n: ^17.10.3
checksum: 10/62a69e0a258b6b0ef8cbb844a3420115ff213648f55e1b3863dd29fa5892de8013f8157317e8279f68b7e82c69c97edc15c0040ad49469756393a711d91b0fff
checksum: 10/541a2df5a21e3e73abd8b5b175fd2c3604bfa8694d7e8e7e48891f01d38396267f1cf92cb88cb181ddd7931dee3c7bf39de59d2cb1f30971a245551d575674a1
languageName: node
linkType: hard

Expand Down Expand Up @@ -3403,7 +3403,7 @@ __metadata:
"@metamask/create-release-branch": "npm:^4.1.3"
"@metamask/eslint-config": "npm:^14.1.0"
"@metamask/eslint-config-jest": "npm:^15.0.0"
"@metamask/eslint-config-nodejs": "npm:^14.0.0"
"@metamask/eslint-config-nodejs": "npm:^15.0.0"
"@metamask/eslint-config-typescript": "npm:^14.1.0"
"@metamask/utils": "npm:^11.8.1"
"@types/eslint-plugin-tailwindcss": "npm:^3"
Expand Down
Loading